Review everything shipped this weekend, and fix what the reviewers caught

Claude-Session: https://claude.ai/code/session_01Ms2FbjQy31TVf3CEvQhGM8

config/dot/quickshell/scripts/panama-osd

@@ -15,25 +15,41 @@ settings_file() {
     printf '%s/panama/settings.json\n' "${XDG_CONFIG_HOME:-$HOME/.config}"
 }
 
-setting_bool() {
-    local key="$1" fallback="$2" file value
+# Both switches the volume keys care about, read in a single jq. A held-down
+# volume key repeats about twenty times a second, and each repeat used to spawn
+# jq twice -- once for the ceiling, once for the click. Prints them as
+# "<overAmplification> <volumeChangeBlip>", falling back to the schema defaults
+# whenever the file cannot be read or does not carry the key.
+volume_settings() {
+    local file value over=false blip=true
     file="$(settings_file)"
-    [[ -r $file ]] || { printf '%s\n' "$fallback"; return 0; }
-    command -v jq >/dev/null 2>&1 || { printf '%s\n' "$fallback"; return 0; }
-    value="$(jq -r --arg key "$key" '
-        if type == "object" and (.[$key] | type) == "boolean" then .[$key] else empty end
-    ' "$file" 2>/dev/null)" || value=""
-    [[ $value == true || $value == false ]] || value="$fallback"
-    printf '%s\n' "$value"
+    if [[ -r $file ]] && command -v jq >/dev/null 2>&1; then
+        value="$(jq -r '
+            def flag($key; $fallback):
+                if type == "object" and (.[$key] | type) == "boolean"
+                then (.[$key] | tostring)
+                else $fallback
+                end;
+            [flag("overAmplification"; "false"), flag("volumeChangeBlip"; "true")]
+                | join(" ")
+        ' "$file" 2>/dev/null)" || value=""
+        read -r over blip <<<"$value"
+        [[ $over == true || $over == false ]] || over=false
+        [[ $blip == true || $blip == false ]] || blip=true
+    fi
+    printf '%s %s\n' "$over" "$blip"
 }
 
-# wpctl clamps to 1.0 by default, and it clamps the *result* -- so the ceiling
-# has to be passed on the way down as well. Without it, stepping down from 130%
-# would snap to 100% instead of 124%, which reads as the slider jumping on its
-# own. The microphone never gets this: gain past 100% on a capture device buys
-# noise, not signal, and the Sound page's input slider stays 0-100 to match.
-volume_limit() {
-    if [[ $(setting_bool overAmplification false) == true ]]; then
+# `wpctl set-volume -l` caps the *result*, and without it wpctl does not cap at
+# all -- 100% is not a ceiling it enforces on its own. So the limit is passed on
+# the way down too, deliberately: with over-amplification off, stepping down
+# from a volume that is somehow already above 100% lands under the ceiling
+# rather than merely one step lower, which is what having the switch off means.
+# The microphone never gets the raised ceiling: gain past 100% on a capture
+# device buys noise, not signal, and the Sound page's input slider stays 0-100
+# to match.
+volume_ceiling() {
+    if [[ $1 == true ]]; then
         printf '1.5\n'
     else
         printf '1\n'
@@ -42,14 +58,28 @@ volume_limit() {
 
 # The click that says the volume moved. Backgrounded and never waited on: it is
 # feedback about something that has already happened, so it must not sit between
-# the key press and the OSD. A distribution without the freedesktop sound theme
-# has no file to play, which is a silent desktop rather than a broken key.
+# the key press and the OSD.
+#
+# Under a non-blocking lock, in the same runtime directory the DDC lock lives in,
+# because key repeat would otherwise start a fresh pw-play over the top of the
+# last one twenty times a second. The first press clicks; the repeats that
+# arrive while it is still sounding are dropped rather than stacked.
+#
+# A distribution without the freedesktop sound theme has no file to play, which
+# is a silent desktop rather than a broken key.
 play_blip() {
+    local enabled="$1"
     local sound="${PANAMA_OSD_BLIP_SOUND:-$PANAMA_OSD_BLIP_DEFAULT}"
-    [[ $(setting_bool volumeChangeBlip true) == true ]] || return 0
+    local runtime_dir="${PANAMA_OSD_RUNTIME_DIR:-${XDG_RUNTIME_DIR:-/tmp}/panama-osd-${UID}}"
+    [[ $enabled == true ]] || return 0
     [[ -f $sound ]] || return 0
-    pw-play "$sound" >/dev/null 2>&1 &
-    disown 2>/dev/null || true
+    mkdir -p "$runtime_dir" 2>/dev/null || return 0
+    chmod 700 "$runtime_dir" 2>/dev/null || true
+    (
+        exec {blip_fd}>"$runtime_dir/blip.lock" || exit 0
+        flock -n "$blip_fd" || exit 0
+        pw-play "$sound" >/dev/null 2>&1
+    ) &
 }
 
 strict_delivery() {
@@ -96,15 +126,17 @@ show_volume() {
 }
 
 adjust_volume() {
-    local action="${1:-}" step="${2:-6}" target="@DEFAULT_AUDIO_SINK@" limit
-    limit="$(volume_limit)"
+    local action="${1:-}" step="${2:-6}" target="@DEFAULT_AUDIO_SINK@"
+    local over blip limit
+    read -r over blip <<<"$(volume_settings)"
+    limit="$(volume_ceiling "$over")"
     case "$action" in
         up) wpctl set-volume -l "$limit" "$target" "${step}%+" || return ;;
         down) wpctl set-volume -l "$limit" "$target" "${step}%-" || return ;;
         toggle) wpctl set-mute "$target" toggle || return ;;
         *) printf 'Usage: panama-osd volume up|down|toggle [step]\n' >&2; return 2 ;;
     esac
-    play_blip
+    play_blip "$blip"
     show_volume "$target" volume
 }