Stop describing a desktop this repository does not install
Phase 5. The README advertised two desktops that coexist -- GNOME with Forge, Dash-to-Dock, Openbar and Vitals, alongside Hyprland -- and nothing in setup/ installed or configured any of the first one. Panama configures one desktop, and now says so. config/dot/forge is deleted along with its entry in link-dotfiles. It was the hedge from when the GNOME session was still the fallback and Hyprland was being built beside it; the hedge has been paid off. Nine files, six of which were Forge's own editor backups that should never have been committed. Searching for the rest of GNOME found nothing else to cut, which is recorded in the spec so nobody goes looking again. change-settings never enabled an extension. The mentions of Dash-to-Dock, Openbar and Vitals through the shell are comments saying what a component was modelled on -- which intellihide behaviour the dock reproduces, where a colour came from -- and DESKTOP-PARITY.md is the table of what replaced what. That is provenance, and it is the reason those components behave the way they do. Vitals in services/ is Panama's own bar service and merely shares a name with the extension it replaced. The handoff panel list was wrong in two places. It named Wacom, which nothing hands off to, and Region, which is a subpage of System rather than a panel. The nine real ones are read off the call sites and the allow-list that gates them. The spec said it, the comment on gnome-control-center repeated it, and the README would have made it three. One test gap turned up and is closed. The assets contract caught a directory under config/dot/ that nothing links, but not the inverse: a name left in the dirs array with nothing behind it, which makes link-dotfiles point ~/.config/<name> at a path that does not exist. Deleting Forge is the exact move that introduces that, and nothing would have failed if the array entry had been left. A dangling symlink is worse than a missing one, because everything that looks there finds something. Verified by putting the entry back and watching it fail. The audit of docs/settings.md this phase asked for needed nothing: it is generated from PreferenceSchema.qml, a contract already fails when it goes stale, and it carries no claim about GNOME or Forge. The README gained the section it was missing instead -- the 121 contracts under tests/ were the main safety net in this repository and went entirely unmentioned in it. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
This commit is contained in:
@@ -187,6 +187,28 @@ for dot_dir in "$repo_dir"/config/dot/*/; do
|
||||
|| note "config/dot/$name is referenced by neither link-dotfiles nor the shell configuration, so nothing puts it into service"
|
||||
done
|
||||
|
||||
# ── 6. Names in the array with nothing behind them ───────────────────────────
|
||||
#
|
||||
# The inverse of the check above, and the one that bites when a directory is
|
||||
# removed rather than added: an entry left in `dirs` makes link-dotfiles point
|
||||
# ~/.config/<name> at a path that does not exist, and a dangling symlink is
|
||||
# worse than no symlink, because everything that looks there finds something.
|
||||
#
|
||||
# Missed the first time this contract was written. Deleting config/dot/forge in
|
||||
# the GNOME excision was caught by nothing until the array entry was removed too,
|
||||
# which was luck rather than a test.
|
||||
|
||||
mapfile -t linked_dirs < <(sed -n '/^dirs=(/,/)/p' "$repo_dir/setup/scripts/link-dotfiles" \
|
||||
| grep -oE '"[^"]+"' | tr -d '"')
|
||||
|
||||
(( ${#linked_dirs[@]} > 0 )) \
|
||||
|| note "link-dotfiles' dirs array could not be read, so nothing checked what it links"
|
||||
|
||||
for name in "${linked_dirs[@]}"; do
|
||||
[[ -d "$repo_dir/config/dot/$name" ]] \
|
||||
|| note "link-dotfiles links $name, but config/dot/$name does not exist -- that is a dangling symlink in ~/.config"
|
||||
done
|
||||
|
||||
# ── Report ───────────────────────────────────────────────────────────────────
|
||||
|
||||
# One asset named by three different files is one finding, not three.
|
||||
|
||||
Reference in New Issue
Block a user