From 78db2d56898ad2a33acec62e61384de95ff6922d Mon Sep 17 00:00:00 2001 From: Gabriel Brown Date: Sat, 22 Aug 2026 09:38:41 -0400 Subject: [PATCH] Let a stepped-over step say why, and let sudo ask soft() swallowed stderr, which hid both halves of what matters: the dnf error explaining the failure, and the sudo password prompt on a machine that asks for one. stdout only. --- setup/scripts/install-packages | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/setup/scripts/install-packages b/setup/scripts/install-packages index e820a7d..c2f28a8 100755 --- a/setup/scripts/install-packages +++ b/setup/scripts/install-packages @@ -33,9 +33,13 @@ packages_in() { # # So the ordering rule for this file: anything that can fail for a reason # outside this repository goes below the desktop, and goes through here. +# stdout only. Swallowing stderr here would hide the one line that says WHY a +# step was stepped over -- and worse, every one of these runs under sudo, whose +# password prompt is the thing you would be hiding on a machine that asks for +# one. soft() { local what="$1"; shift - "$@" >/dev/null 2>&1 || { log "$what did not complete; continuing"; softly_failed+=("$what"); } + "$@" >/dev/null || { log "$what did not complete; continuing"; softly_failed+=("$what"); } } softly_failed=()