Let a machine say what it is for, and give Firefox its face back
Phase 4: the optional application categories, and the Firefox chrome. Everything Panama installed until now was what every machine gets, which meant a work laptop acquired emulators and a desktop that wanted Steam had to be told about it by hand. The interview now offers the categories in setup/packages/extras/ as a checklist -- gaming, creative, communication, virtualization -- and nothing is preselected, because a default here installs applications nobody chose on a machine whose owner answered a question they thought was about something else. A category is one file, and a category mixes both package managers because the applications do: Steam is in RPM Fusion, Slack publishes only a flatpak. So a bare line is a dnf package and a flatpak: line is a Flathub ID, and one file holds the whole answer rather than splitting each category across two. The menu is read from the directory rather than written down, so adding a category is adding a file. Every name in all four was resolved against the actual repositories before being written down, and the contract re-resolves them -- the point of admitting applications one at a time is that they stay installable, and a typo here fails on somebody else's machine, not this one. Firefox is declared, and its chrome is Edge-Frfox, vendored into config/firefox. sunhat carried that theme with no license and no attribution; it is MIT, and now it says so and says whose it is. It is the only piece of Panama's configuration that does not go to a path this repository chooses. Firefox owns the profile directory, names it with a random salt, and does not create one until the browser has been run -- so link-dotfiles finds or creates a profile and links both halves into it. Both, or neither works: chrome/ is the CSS and user.js sets the preference that makes Firefox read chrome/ at all, without which the theme is a directory of dead files. Two assumptions there were wrong, and the contract exists for both. Firefox has moved to the XDG directories -- the profile root is ~/.config/mozilla/firefox on this build, not ~/.mozilla/firefox, and writing to the wrong one themes nothing and says nothing about it. And -CreateProfile turns out to be non-interactive, so a fresh machine gets the theme on the first install rather than the second. The contract runs link-dotfiles for real against a throwaway home with no profile in it and looks at what came out; it was checked by pointing the search at the legacy path only and watching it fail. Also: the enrolment/enrollment spellings from the last commit are corrected. This repository is US-spelled everywhere else -- color 1131 times against colour never -- and consistency in prose is worth as much as it is in code. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
This commit is contained in:
Gabriel Brown
Executable
+165
@@ -0,0 +1,165 @@
|
||||
#!/usr/bin/env bash
|
||||
|
||||
# The optional application categories: what the interview offers, and what
|
||||
# choosing one actually installs.
|
||||
#
|
||||
# The rules:
|
||||
#
|
||||
# 1. Every category the interview offers installs something. The menu is read
|
||||
# from the directory rather than written down, so an empty or missing file
|
||||
# is a checkbox that does nothing -- the same defect this repository has
|
||||
# refused to ship twice now.
|
||||
# 2. A `flatpak:` line reaches flatpak with the prefix removed, and never
|
||||
# reaches dnf. Getting this backwards installs nothing and says it did.
|
||||
# 3. Nothing is installed without being asked for. An extras loop that ran on
|
||||
# its own defaults would put Steam on a work laptop.
|
||||
# 4. Every name is a real package. The whole point of admitting applications
|
||||
# one at a time from dnf or Flathub is that they stay installable; a typo
|
||||
# here is a category that fails on somebody else's machine, not this one.
|
||||
# Checked against the actual repositories, and skipped when offline.
|
||||
|
||||
set -uo pipefail
|
||||
|
||||
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
||||
installer="$repo_dir/setup/scripts/install-packages"
|
||||
interview="$repo_dir/setup/scripts/interview"
|
||||
extras_dir="$repo_dir/setup/packages/extras"
|
||||
|
||||
findings=()
|
||||
note() { findings+=("$1"); }
|
||||
|
||||
[[ -d "$extras_dir" ]] || { printf 'extras contract: no %s\n' "$extras_dir" >&2; exit 1; }
|
||||
|
||||
# ── 1. Every category is a real offer ────────────────────────────────────────
|
||||
|
||||
shopt -s nullglob
|
||||
categories=("$extras_dir"/*)
|
||||
(( ${#categories[@]} > 0 )) || note 'the extras directory is empty, so the checklist offers nothing'
|
||||
|
||||
for category in "${categories[@]}"; do
|
||||
name="$(basename "$category")"
|
||||
[[ -f "$category" ]] || { note "$name is not a file"; continue; }
|
||||
entries="$(sed 's/#.*//' "$category" | tr -d ' \t' | grep -cv '^$')"
|
||||
(( entries > 0 )) || note "the $name category installs nothing, so choosing it does nothing"
|
||||
done
|
||||
|
||||
# The menu has to come from the directory. A hardcoded list is one that goes
|
||||
# stale the first time a category is added.
|
||||
grep -q 'extras_dir' "$interview" \
|
||||
|| note 'the interview does not read the categories from the extras directory'
|
||||
grep -q 'gum choose --no-limit' "$interview" \
|
||||
|| note 'the interview does not offer the categories as a multiple-choice checklist'
|
||||
|
||||
# ── 2 & 3. What a chosen category actually installs ──────────────────────────
|
||||
|
||||
work="$(mktemp -d)"
|
||||
trap 'rm -rf "$work"' EXIT
|
||||
|
||||
filter="$(sed -n '/^packages_in()/,/^}/p' "$installer")"
|
||||
loop="$(sed -n '/^install_extra_category()/,/^}/p' "$installer")"
|
||||
[[ -n "$filter" && -n "$loop" ]] || {
|
||||
printf 'extras contract: install-packages no longer defines packages_in and install_extra_category\n' >&2
|
||||
exit 1
|
||||
}
|
||||
|
||||
stub_dir="$work/bin"
|
||||
mkdir -p "$stub_dir"
|
||||
calls="$work/calls"
|
||||
for command in dnf flatpak; do
|
||||
cat >"$stub_dir/$command" <<STUB
|
||||
#!/usr/bin/env bash
|
||||
printf '%s %s\n' "$command" "\$*" >>"$calls"
|
||||
STUB
|
||||
chmod +x "$stub_dir/$command"
|
||||
done
|
||||
cat >"$stub_dir/sudo" <<'STUB'
|
||||
#!/usr/bin/env bash
|
||||
exec "$@"
|
||||
STUB
|
||||
chmod +x "$stub_dir/sudo"
|
||||
|
||||
fixture="$work/mixed"
|
||||
cat >"$fixture" <<'LIST'
|
||||
# Both managers in one category, which is the case this format exists for.
|
||||
from-dnf
|
||||
flatpak:org.example.FromFlathub
|
||||
LIST
|
||||
|
||||
(
|
||||
PATH="$stub_dir:$PATH"
|
||||
log() { :; }
|
||||
eval "$filter"
|
||||
eval "$loop"
|
||||
install_extra_category "$fixture"
|
||||
)
|
||||
|
||||
recorded="$(cat "$calls" 2>/dev/null)"
|
||||
|
||||
grep -q 'dnf install -y from-dnf' <<<"$recorded" \
|
||||
|| note 'a bare line in a category is not installed with dnf'
|
||||
grep -q 'flatpak install -y flathub org.example.FromFlathub' <<<"$recorded" \
|
||||
|| note 'a flatpak: line does not reach flatpak with the prefix removed'
|
||||
if grep 'dnf install' <<<"$recorded" | grep -q 'flatpak:'; then
|
||||
note 'a flatpak: line is passed to dnf, which cannot install it'
|
||||
fi
|
||||
if grep 'flatpak install' <<<"$recorded" | grep -q 'from-dnf'; then
|
||||
note 'a dnf package is passed to flatpak'
|
||||
fi
|
||||
|
||||
# Choosing nothing installs nothing.
|
||||
: >"$calls"
|
||||
(
|
||||
PATH="$stub_dir:$PATH"
|
||||
PANAMA_PATH="$repo_dir"
|
||||
log() { :; }
|
||||
eval "$filter"
|
||||
eval "$loop"
|
||||
EXTRAS_DIR="$extras_dir"
|
||||
for extra in ${PANAMA_EXTRAS:-}; do
|
||||
[[ -f "$EXTRAS_DIR/$extra" ]] && install_extra_category "$EXTRAS_DIR/$extra"
|
||||
done
|
||||
)
|
||||
[[ -s "$calls" ]] && note 'with no categories chosen the installer still installed something'
|
||||
|
||||
# ── 4. Every name resolves ───────────────────────────────────────────────────
|
||||
#
|
||||
# Skipped rather than failed when the repositories cannot be reached, so this
|
||||
# contract stays runnable on a train.
|
||||
|
||||
if timeout 60 dnf list --available --quiet bash >/dev/null 2>&1; then
|
||||
for category in "${categories[@]}"; do
|
||||
[[ -f "$category" ]] || continue
|
||||
while read -r package; do
|
||||
[[ -n "$package" ]] || continue
|
||||
[[ "$package" == flatpak:* ]] && continue
|
||||
timeout 90 dnf list --quiet "$package" >/dev/null 2>&1 \
|
||||
|| note "$(basename "$category") names $package, which dnf cannot resolve"
|
||||
done < <(sed 's/#.*//' "$category" | tr -d ' \t' | grep -v '^$')
|
||||
done
|
||||
else
|
||||
printf 'extras contract: dnf is unreachable, so package names were not resolved\n' >&2
|
||||
fi
|
||||
|
||||
if timeout 60 flatpak remote-info flathub org.mozilla.firefox >/dev/null 2>&1; then
|
||||
for category in "${categories[@]}"; do
|
||||
[[ -f "$category" ]] || continue
|
||||
while read -r id; do
|
||||
[[ -n "$id" ]] || continue
|
||||
timeout 90 flatpak remote-info flathub "$id" >/dev/null 2>&1 \
|
||||
|| note "$(basename "$category") names $id, which is not on Flathub"
|
||||
done < <(sed 's/#.*//' "$category" | tr -d ' \t' | sed -n 's/^flatpak://p')
|
||||
done
|
||||
else
|
||||
printf 'extras contract: Flathub is unreachable, so flatpak IDs were not resolved\n' >&2
|
||||
fi
|
||||
|
||||
# ── Report ───────────────────────────────────────────────────────────────────
|
||||
|
||||
if (( ${#findings[@]} > 0 )); then
|
||||
mapfile -t findings < <(printf '%s\n' "${findings[@]}" | sort -u)
|
||||
printf 'extras contract: %d finding(s)\n' "${#findings[@]}" >&2
|
||||
printf ' - %s\n' "${findings[@]}" >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
printf 'extras contract: PASS (%d categories)\n' "${#categories[@]}"
|
||||
Reference in New Issue
Block a user