Coherence: one component per idea, one spelling per word, one truth per claim

Claude-Session: https://claude.ai/code/session_01Ms2FbjQy31TVf3CEvQhGM8
This commit is contained in:
Gabriel Brown
2026-08-25 02:21:45 -04:00
parent 06c53d6c21
commit bd2fd12de2
87 changed files with 660 additions and 766 deletions
@@ -12,7 +12,6 @@
import Quickshell
import QtQuick
import qs.config
import qs.services
SettingsPage {
@@ -133,14 +132,11 @@ SettingsPage {
return text;
}
Component.onCompleted: Firewall.refresh()
Component.onCompleted: if (!Firewall.scanned) Firewall.refresh()
TextRow {
visible: Firewall.lastError !== ""
ErrorRow {
label: "The firewall needs attention"
detail: Firewall.lastError
value: ""
divider: false
message: Firewall.lastError
}
// ── The finding, when there is one ───────────────────────────────────────
@@ -378,7 +374,7 @@ SettingsPage {
: (root.addKind === "service"
? "That is not a service name firewalld would accept"
: "That is not a port firewalld would accept")
detail: "This writes a permanent rule — the system will ask for your password."
detail: "This writes a permanent rule — the system will ask for your password"
action: "Allow"
enabled: root.addValid && !Firewall.busy
divider: false
@@ -565,43 +561,16 @@ SettingsPage {
Repeater {
model: Firewall.allZones ?? []
delegate: Rectangle {
delegate: SettingsChip {
id: chip
required property var modelData
readonly property string zoneName: String(chip.modelData)
readonly property bool current: root.browsingZone === chip.zoneName
width: chipLabel.implicitWidth + 20
height: 26
radius: Theme.pillRadius
color: chip.current
? Theme.alpha(Theme.accent, 0.18)
: Theme.alpha(Theme.fg, chipHover.hovered ? 0.11 : 0.055)
border.width: 1
border.color: chip.current
? Theme.alpha(Theme.accent, 0.45)
: Theme.alpha(Theme.fg, 0.09)
Text {
id: chipLabel
anchors.centerIn: parent
text: chip.zoneName
color: chip.current ? Theme.fg : Theme.fgDim
font.family: Theme.fontFamily
font.pixelSize: Theme.fontSizeSmall
font.weight: chip.current ? Font.DemiBold : Font.Normal
}
HoverHandler {
id: chipHover
cursorShape: Qt.PointingHandCursor
}
TapHandler {
onTapped: root.browsingZone = chip.current ? "" : chip.zoneName
}
text: chip.zoneName
active: root.browsingZone === chip.zoneName
onClicked: root.browsingZone = chip.active ? "" : chip.zoneName
}
}
}