Drop the extension, and give the test suite a front door
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
This commit is contained in:
Gabriel Brown
@@ -33,8 +33,8 @@
|
||||
- `config/dot/quickshell/scripts/calendar-agenda` — executable Python bridge; the only code that imports EDS libraries.
|
||||
- `config/dot/quickshell/services/CalendarAgenda.qml` — singleton state consumed by shell UI; supervises the bridge and owns date-derived selectors.
|
||||
- `tests/quickshell/calendar_agenda_bridge_test.py` — pure normalization and URL-policy tests using synthetic components only.
|
||||
- `tests/quickshell/calendar-agenda-helper-contract.sh` — executable/probe/live-query contract that redacts live content.
|
||||
- `tests/quickshell/calendar-agenda-contract.sh` — live Quickshell IPC/state contract using synthetic in-memory fixtures.
|
||||
- `tests/quickshell/calendar-agenda-helper-contract` — executable/probe/live-query contract that redacts live content.
|
||||
- `tests/quickshell/calendar-agenda-contract` — live Quickshell IPC/state contract using synthetic in-memory fixtures.
|
||||
|
||||
### Daybook presentation
|
||||
|
||||
@@ -67,7 +67,7 @@
|
||||
**Files:**
|
||||
- Create: `config/dot/quickshell/scripts/calendar-agenda`
|
||||
- Create: `tests/quickshell/calendar_agenda_bridge_test.py`
|
||||
- Create: `tests/quickshell/calendar-agenda-helper-contract.sh`
|
||||
- Create: `tests/quickshell/calendar-agenda-helper-contract`
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: enabled sources returned by `EDataServer.SourceRegistry.list_enabled(EDataServer.SOURCE_EXTENSION_CALENDAR)`.
|
||||
@@ -229,7 +229,7 @@ Expected: four tests PASS.
|
||||
|
||||
- [x] **Step 5: Add the redacted live helper contract**
|
||||
|
||||
Create `tests/quickshell/calendar-agenda-helper-contract.sh` with:
|
||||
Create `tests/quickshell/calendar-agenda-helper-contract` with:
|
||||
|
||||
```bash
|
||||
#!/usr/bin/env bash
|
||||
@@ -265,7 +265,7 @@ Make it executable and run it. Expected: PASS with counts only; no source names,
|
||||
```bash
|
||||
git add config/dot/quickshell/scripts/calendar-agenda \
|
||||
tests/quickshell/calendar_agenda_bridge_test.py \
|
||||
tests/quickshell/calendar-agenda-helper-contract.sh
|
||||
tests/quickshell/calendar-agenda-helper-contract
|
||||
git commit -m "Add the EDS calendar bridge"
|
||||
```
|
||||
|
||||
@@ -275,7 +275,7 @@ git commit -m "Add the EDS calendar bridge"
|
||||
|
||||
**Files:**
|
||||
- Create: `config/dot/quickshell/services/CalendarAgenda.qml`
|
||||
- Create: `tests/quickshell/calendar-agenda-contract.sh`
|
||||
- Create: `tests/quickshell/calendar-agenda-contract`
|
||||
- Modify: `config/dot/quickshell/shell.qml`
|
||||
|
||||
**Interfaces:**
|
||||
@@ -286,7 +286,7 @@ git commit -m "Add the EDS calendar bridge"
|
||||
|
||||
- [x] **Step 1: Write the failing live service contract**
|
||||
|
||||
Create `tests/quickshell/calendar-agenda-contract.sh` that first asserts the IPC target, loads fixture `daybook`, and validates only synthetic state:
|
||||
Create `tests/quickshell/calendar-agenda-contract` that first asserts the IPC target, loads fixture `daybook`, and validates only synthetic state:
|
||||
|
||||
```bash
|
||||
#!/usr/bin/env bash
|
||||
@@ -317,7 +317,7 @@ printf 'calendar agenda contract: PASS\n'
|
||||
|
||||
- [x] **Step 2: Run the contract and verify RED**
|
||||
|
||||
Run `tests/quickshell/calendar-agenda-contract.sh`.
|
||||
Run `tests/quickshell/calendar-agenda-contract`.
|
||||
|
||||
Expected: FAIL with `calendar IPC target is missing`.
|
||||
|
||||
@@ -385,8 +385,8 @@ Do not include titles, source names, locations, identifiers, or URLs in status o
|
||||
Allow Quickshell to hot reload, then run:
|
||||
|
||||
```bash
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-helper-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
tests/quickshell/calendar-agenda-helper-contract
|
||||
qs log -n -t 80 --no-color | rg -i 'calendar|error|warn'
|
||||
```
|
||||
|
||||
@@ -397,7 +397,7 @@ Expected: both contracts PASS; no calendar QML error or bridge restart loop.
|
||||
```bash
|
||||
git add config/dot/quickshell/services/CalendarAgenda.qml \
|
||||
config/dot/quickshell/shell.qml \
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
git commit -m "Add live calendar state to Quickshell"
|
||||
```
|
||||
|
||||
@@ -410,7 +410,7 @@ git commit -m "Add live calendar state to Quickshell"
|
||||
- Modify: `config/dot/quickshell/modules/bar/Clock.qml`
|
||||
- Modify: `config/dot/quickshell/shell.qml`
|
||||
- Modify: `config/dot/quickshell/modules/datemenu/CalendarGrid.qml`
|
||||
- Modify: `tests/quickshell/calendar-agenda-contract.sh`
|
||||
- Modify: `tests/quickshell/calendar-agenda-contract`
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: `CalendarAgenda.selectDate(date)` and `CalendarAgenda.markersForDate(date)`.
|
||||
@@ -489,7 +489,7 @@ Month changes call `visibleMonthChanged(viewYear, viewMonth)`. Adjacent-month da
|
||||
Run:
|
||||
|
||||
```bash
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
rg -q 'markersForDate' config/dot/quickshell/modules/datemenu/CalendarGrid.qml
|
||||
rg -q 'dateActivated' config/dot/quickshell/modules/datemenu/CalendarGrid.qml
|
||||
```
|
||||
@@ -503,7 +503,7 @@ git add config/dot/quickshell/services/ShellState.qml \
|
||||
config/dot/quickshell/modules/bar/Clock.qml \
|
||||
config/dot/quickshell/shell.qml \
|
||||
config/dot/quickshell/modules/datemenu/CalendarGrid.qml \
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
git commit -m "Route the interactive Panama date menu"
|
||||
```
|
||||
|
||||
@@ -519,7 +519,7 @@ git commit -m "Route the interactive Panama date menu"
|
||||
- Modify: `config/dot/quickshell/modules/datemenu/DateMenu.qml`
|
||||
- Modify: `config/dot/quickshell/modules/datemenu/MediaCard.qml`
|
||||
- Modify: `config/dot/quickshell/modules/datemenu/qmldir`
|
||||
- Modify: `tests/quickshell/calendar-agenda-contract.sh`
|
||||
- Modify: `tests/quickshell/calendar-agenda-contract`
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: `CalendarAgenda.selectedEvents`, `nextEventForSelectedDate`, `phase`, and action functions.
|
||||
@@ -623,7 +623,7 @@ Run:
|
||||
```bash
|
||||
qs ipc call calendar-agenda fixture daybook
|
||||
qs ipc call calendar-agenda open
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
```
|
||||
|
||||
Capture a temporary full-screen screenshot with `grim`, inspect the Daybook at original detail, and verify:
|
||||
@@ -641,7 +641,7 @@ Close the panel and reset fixture mode after inspection. Do not add screenshots
|
||||
|
||||
```bash
|
||||
git add config/dot/quickshell/modules/datemenu \
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
git commit -m "Build the Prism calendar Daybook"
|
||||
```
|
||||
|
||||
@@ -653,7 +653,7 @@ git commit -m "Build the Prism calendar Daybook"
|
||||
- Create: `config/dot/quickshell/modules/bar/CalendarIndicator.qml`
|
||||
- Modify: `config/dot/quickshell/modules/bar/Bar.qml`
|
||||
- Modify: `config/dot/quickshell/services/CalendarAgenda.qml`
|
||||
- Modify: `tests/quickshell/calendar-agenda-contract.sh`
|
||||
- Modify: `tests/quickshell/calendar-agenda-contract`
|
||||
|
||||
**Interfaces:**
|
||||
- Consumes: `CalendarAgenda.capsuleVisible`, `capsuleText`, and `nextEvent`.
|
||||
@@ -693,8 +693,8 @@ Use a single 120 ms opacity/width entrance tied to visibility. No looping animat
|
||||
- [x] **Step 4: Run capsule and full shell contracts**
|
||||
|
||||
```bash
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
for test in tests/quickshell/*.sh; do "$test"; done
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
for test in tests/quickshell/*; do "$test"; done
|
||||
```
|
||||
|
||||
Expected: calendar fixture boundaries PASS and every existing Quickshell contract remains green.
|
||||
@@ -705,7 +705,7 @@ Expected: calendar fixture boundaries PASS and every existing Quickshell contrac
|
||||
git add config/dot/quickshell/modules/bar/CalendarIndicator.qml \
|
||||
config/dot/quickshell/modules/bar/Bar.qml \
|
||||
config/dot/quickshell/services/CalendarAgenda.qml \
|
||||
tests/quickshell/calendar-agenda-contract.sh
|
||||
tests/quickshell/calendar-agenda-contract
|
||||
git commit -m "Add the quiet calendar capsule"
|
||||
```
|
||||
|
||||
@@ -745,7 +745,7 @@ Remove `qrencode` from `setup/packages/hyprland-packages` only if `rg -n qrencod
|
||||
- [x] **Step 2: Run static verification**
|
||||
|
||||
```bash
|
||||
bash -n tests/quickshell/*.sh config/dot/quickshell/scripts/screen-intelligence
|
||||
bash -n tests/quickshell/* config/dot/quickshell/scripts/screen-intelligence
|
||||
python3 -c 'compile(open("config/dot/quickshell/scripts/calendar-agenda", encoding="utf-8").read(), "calendar-agenda", "exec")'
|
||||
python3 tests/quickshell/calendar_agenda_bridge_test.py
|
||||
desktop-file-validate config/local/share/applications/*.desktop
|
||||
@@ -758,7 +758,7 @@ Expected: every command exits 0 and Hyprland reports `config ok`.
|
||||
- [x] **Step 3: Run every Quickshell contract**
|
||||
|
||||
```bash
|
||||
for test in tests/quickshell/*.sh; do
|
||||
for test in tests/quickshell/*; do
|
||||
"$test"
|
||||
done
|
||||
```
|
||||
|
||||
Reference in New Issue
Block a user