Drop the extension, and give the test suite a front door
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
This commit is contained in:
Gabriel Brown
@@ -33,14 +33,14 @@
|
||||
|
||||
- `config/dot/quickshell/scripts/panama-kdeconnect` — validates device/file inputs, normalizes device/plugin status, and invokes allow-listed actions.
|
||||
- `tests/quickshell/kdeconnect_bridge_test.py` — pure parser, capability, validation, and command tests with fake runners.
|
||||
- `tests/quickshell/kdeconnect-helper-contract.sh` — live read-only status contract with names and IDs redacted.
|
||||
- `tests/quickshell/kdeconnect-helper-contract` — live read-only status contract with names and IDs redacted.
|
||||
- `config/dot/quickshell/services/KdeConnect.qml` — singleton device, action, transfer, fixture, and recent-exchange state.
|
||||
|
||||
### Home Assistant boundary
|
||||
|
||||
- `config/dot/quickshell/scripts/panama-home-assistant` — configuration resolution, normalized REST reads, allow-listed toggles, and URL handoff.
|
||||
- `tests/quickshell/home_assistant_bridge_test.py` — local fake API and credential/configuration precedence tests.
|
||||
- `tests/quickshell/home-assistant-helper-contract.sh` — live read-only probe/snapshot contract with entity content redacted.
|
||||
- `tests/quickshell/home-assistant-helper-contract` — live read-only probe/snapshot contract with entity content redacted.
|
||||
- `config/dot/quickshell/services/HomeAssistant.qml` — singleton entities, stale state, per-entity action state, fixture, and inline errors.
|
||||
|
||||
### Control Center presentation and integration
|
||||
@@ -58,8 +58,8 @@
|
||||
- `config/dot/quickshell/services/Ongoing.qml` — append and control one running phone transfer.
|
||||
- `config/dot/quickshell/services/StatusEvents.qml` — open a completed received/sent path through the existing allow-listed action.
|
||||
- `config/dot/quickshell/shell.qml` — diagnostics/fixture IPC for the two services.
|
||||
- `tests/quickshell/control-center-services-contract.sh` — deterministic service, activity, and event contract.
|
||||
- `tests/quickshell/control-center-contract.sh` — panel geometry, routing, components, and live layer contract.
|
||||
- `tests/quickshell/control-center-services-contract` — deterministic service, activity, and event contract.
|
||||
- `tests/quickshell/control-center-contract` — panel geometry, routing, components, and live layer contract.
|
||||
|
||||
### Documentation
|
||||
|
||||
@@ -73,7 +73,7 @@
|
||||
**Files:**
|
||||
- Create: `config/dot/quickshell/scripts/panama-kdeconnect`
|
||||
- Create: `tests/quickshell/kdeconnect_bridge_test.py`
|
||||
- Create: `tests/quickshell/kdeconnect-helper-contract.sh`
|
||||
- Create: `tests/quickshell/kdeconnect-helper-contract`
|
||||
|
||||
**Interfaces:**
|
||||
- Produces: `panama-kdeconnect status` JSON with `available` and `devices`.
|
||||
@@ -185,7 +185,7 @@ Expected: all cases PASS with no device name, address, or file path printed by t
|
||||
|
||||
- [ ] **Step 5: Add and run the redacted live contract**
|
||||
|
||||
Create `tests/quickshell/kdeconnect-helper-contract.sh` that runs `status` and asserts:
|
||||
Create `tests/quickshell/kdeconnect-helper-contract` that runs `status` and asserts:
|
||||
|
||||
```bash
|
||||
jq -e '
|
||||
@@ -203,7 +203,7 @@ Print only `PASS (N paired, N reachable; identities redacted)`.
|
||||
```bash
|
||||
git add config/dot/quickshell/scripts/panama-kdeconnect \
|
||||
tests/quickshell/kdeconnect_bridge_test.py \
|
||||
tests/quickshell/kdeconnect-helper-contract.sh
|
||||
tests/quickshell/kdeconnect-helper-contract
|
||||
git commit -m "Add the Panama KDE Connect bridge"
|
||||
```
|
||||
|
||||
@@ -214,7 +214,7 @@ git commit -m "Add the Panama KDE Connect bridge"
|
||||
**Files:**
|
||||
- Create: `config/dot/quickshell/scripts/panama-home-assistant`
|
||||
- Create: `tests/quickshell/home_assistant_bridge_test.py`
|
||||
- Create: `tests/quickshell/home-assistant-helper-contract.sh`
|
||||
- Create: `tests/quickshell/home-assistant-helper-contract`
|
||||
|
||||
**Interfaces:**
|
||||
- Produces: `probe`, `snapshot`, `toggle ENTITY_ID`, and `open`.
|
||||
@@ -348,7 +348,7 @@ The contract runs `probe` and `snapshot`, validates the schema, and prints only
|
||||
```bash
|
||||
git add config/dot/quickshell/scripts/panama-home-assistant \
|
||||
tests/quickshell/home_assistant_bridge_test.py \
|
||||
tests/quickshell/home-assistant-helper-contract.sh
|
||||
tests/quickshell/home-assistant-helper-contract
|
||||
git commit -m "Add the Panama Home Assistant bridge"
|
||||
```
|
||||
|
||||
@@ -359,7 +359,7 @@ git commit -m "Add the Panama Home Assistant bridge"
|
||||
**Files:**
|
||||
- Create: `config/dot/quickshell/services/KdeConnect.qml`
|
||||
- Create: `config/dot/quickshell/services/HomeAssistant.qml`
|
||||
- Create: `tests/quickshell/control-center-services-contract.sh`
|
||||
- Create: `tests/quickshell/control-center-services-contract`
|
||||
- Modify: `config/dot/quickshell/services/DeviceEvents.qml`
|
||||
- Modify: `config/dot/quickshell/services/Ongoing.qml`
|
||||
- Modify: `config/dot/quickshell/shell.qml`
|
||||
@@ -396,7 +396,7 @@ Cleanup resets both fixture modes and closes Quick Settings.
|
||||
|
||||
- [ ] **Step 2: Run the contract and verify RED**
|
||||
|
||||
Run `tests/quickshell/control-center-services-contract.sh`.
|
||||
Run `tests/quickshell/control-center-services-contract`.
|
||||
|
||||
Expected: FAIL because the IPC targets do not exist.
|
||||
|
||||
@@ -456,7 +456,7 @@ Run the repository's established shell reload command, wait for the current
|
||||
instance to report IPC, then run:
|
||||
|
||||
```bash
|
||||
tests/quickshell/control-center-services-contract.sh
|
||||
tests/quickshell/control-center-services-contract
|
||||
```
|
||||
|
||||
Expected: PASS with fixture state only and no QML warnings in the fresh journal.
|
||||
@@ -469,7 +469,7 @@ git add config/dot/quickshell/services/KdeConnect.qml \
|
||||
config/dot/quickshell/services/DeviceEvents.qml \
|
||||
config/dot/quickshell/services/Ongoing.qml \
|
||||
config/dot/quickshell/shell.qml \
|
||||
tests/quickshell/control-center-services-contract.sh
|
||||
tests/quickshell/control-center-services-contract
|
||||
git commit -m "Add Control Center integration services"
|
||||
```
|
||||
|
||||
@@ -483,7 +483,7 @@ git commit -m "Add Control Center integration services"
|
||||
- Create: `config/dot/quickshell/modules/quicksettings/HomeTile.qml`
|
||||
- Create: `config/dot/quickshell/modules/quicksettings/PhoneControls.qml`
|
||||
- Create: `config/dot/quickshell/modules/quicksettings/RecentExchange.qml`
|
||||
- Create: `tests/quickshell/control-center-contract.sh`
|
||||
- Create: `tests/quickshell/control-center-contract`
|
||||
- Modify: `config/dot/quickshell/config/Theme.qml`
|
||||
- Modify: `config/dot/quickshell/modules/quicksettings/QuickSettings.qml`
|
||||
- Modify: `config/dot/quickshell/modules/quicksettings/QuickSettingsPanel.qml`
|
||||
@@ -514,7 +514,7 @@ Phone leaves only Phone expanded.
|
||||
|
||||
- [ ] **Step 2: Run the contract and verify RED**
|
||||
|
||||
Run `tests/quickshell/control-center-contract.sh`.
|
||||
Run `tests/quickshell/control-center-contract`.
|
||||
|
||||
Expected: FAIL on the missing geometry tokens and components.
|
||||
|
||||
@@ -568,7 +568,7 @@ animation.
|
||||
|
||||
- [ ] **Step 7: Restart Quickshell and run the panel contract GREEN**
|
||||
|
||||
Run `tests/quickshell/control-center-contract.sh` and inspect the fresh shell
|
||||
Run `tests/quickshell/control-center-contract` and inspect the fresh shell
|
||||
journal for `error`, `warning`, `ReferenceError`, and `TypeError` entries from
|
||||
the current Quickshell start.
|
||||
|
||||
@@ -581,7 +581,7 @@ fixture screenshots to `/tmp`; do not commit screenshots.
|
||||
git add config/dot/quickshell/config/Theme.qml \
|
||||
config/dot/quickshell/modules/quicksettings \
|
||||
config/dot/quickshell/modules/bar/StatusCluster.qml \
|
||||
tests/quickshell/control-center-contract.sh
|
||||
tests/quickshell/control-center-contract
|
||||
git commit -m "Build the Panama Control Center"
|
||||
```
|
||||
|
||||
@@ -610,10 +610,10 @@ retaining printers and the external RustDesk lock-screen test.
|
||||
```bash
|
||||
python3 tests/quickshell/kdeconnect_bridge_test.py
|
||||
python3 tests/quickshell/home_assistant_bridge_test.py
|
||||
tests/quickshell/kdeconnect-helper-contract.sh
|
||||
tests/quickshell/home-assistant-helper-contract.sh
|
||||
tests/quickshell/control-center-services-contract.sh
|
||||
tests/quickshell/control-center-contract.sh
|
||||
tests/quickshell/kdeconnect-helper-contract
|
||||
tests/quickshell/home-assistant-helper-contract
|
||||
tests/quickshell/control-center-services-contract
|
||||
tests/quickshell/control-center-contract
|
||||
```
|
||||
|
||||
Expected: every command exits 0; live contracts print counts only.
|
||||
@@ -621,7 +621,7 @@ Expected: every command exits 0; live contracts print counts only.
|
||||
- [ ] **Step 3: Run full Panama verification**
|
||||
|
||||
Run `hyprctl configerrors` and require empty output. Run every executable
|
||||
`tests/quickshell/*contract.sh` in sorted order and require zero failures.
|
||||
`tests/quickshell/*contract` in sorted order and require zero failures.
|
||||
Restart Quickshell from a clean process, verify all IPC targets return, and
|
||||
inspect only the new process's journal for QML errors or warnings.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user