Drop the extension, and give the test suite a front door
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
This commit is contained in:
Gabriel Brown
+153
@@ -0,0 +1,153 @@
|
||||
#!/usr/bin/env bash
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
||||
shipped_idle="$repo_dir/config/dot/hypr/hypridle.conf"
|
||||
idle_helper="$repo_dir/config/dot/quickshell/scripts/panama-idle"
|
||||
fixture="$(mktemp -d /tmp/panama-lock-service.XXXXXX)"
|
||||
config_home="$fixture/config"
|
||||
state_home="$fixture/state"
|
||||
config_path="$config_home/quickshell"
|
||||
harness="$config_path/lock-screen-harness.qml"
|
||||
test_bin="$fixture/bin"
|
||||
generate_log="$fixture/generate.log"
|
||||
status_response="$fixture/status.json"
|
||||
shell_log="$fixture/quickshell.log"
|
||||
harness_pid=""
|
||||
|
||||
fail() {
|
||||
printf 'lock screen service contract: %s\n' "$1" >&2
|
||||
[[ -s "$shell_log" ]] && sed -n '1,160p' "$shell_log" >&2
|
||||
exit 1
|
||||
}
|
||||
|
||||
instances_for_harness() {
|
||||
qs list --all 2>/dev/null | awk -v expected="$harness" '
|
||||
/^Instance / { pid = "" }
|
||||
/^[[:space:]]*Process ID:/ { pid = $3 }
|
||||
/^[[:space:]]*Config path:/ {
|
||||
path = $0
|
||||
sub(/^[[:space:]]*Config path: /, "", path)
|
||||
if (path == expected && pid ~ /^[0-9]+$/) print pid
|
||||
}
|
||||
'
|
||||
}
|
||||
|
||||
cleanup() {
|
||||
if [[ "$harness_pid" =~ ^[0-9]+$ ]] && kill -0 "$harness_pid" 2>/dev/null; then
|
||||
kill "$harness_pid" 2>/dev/null || true
|
||||
fi
|
||||
rm -rf "$fixture"
|
||||
}
|
||||
trap cleanup EXIT
|
||||
|
||||
expected_lock='lock_cmd = pidof hyprlock || ~/.config/quickshell/scripts/panama-lock run'
|
||||
rg -Fxq " $expected_lock" "$shipped_idle" || fail 'shipped hypridle does not use panama-lock'
|
||||
|
||||
mkdir -p "$config_home/panama" "$state_home" "$test_bin"
|
||||
printf '%s\n' '{}' >"$config_home/panama/settings.json"
|
||||
cat >"$test_bin/systemctl" <<'EOF'
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
if [[ "$*" == *"is-active"* ]]; then printf 'active\n'; fi
|
||||
EOF
|
||||
chmod +x "$test_bin/systemctl"
|
||||
HOME="$fixture/home" XDG_CONFIG_HOME="$config_home" XDG_STATE_HOME="$state_home" \
|
||||
PATH="$test_bin:$PATH" "$idle_helper" apply
|
||||
rg -Fxq " $expected_lock" "$state_home/panama/hypridle.conf" \
|
||||
|| fail 'generated hypridle does not use panama-lock'
|
||||
|
||||
cp -a "$repo_dir/config/dot/quickshell" "$config_path"
|
||||
cat >"$config_path/scripts/panama-lock" <<'EOF'
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
case "${1:-}" in
|
||||
generate)
|
||||
printf 'generate\n' >>"$PANAMA_LOCK_TEST_GENERATE_LOG"
|
||||
;;
|
||||
status)
|
||||
cat "$PANAMA_LOCK_TEST_STATUS_RESPONSE"
|
||||
;;
|
||||
*) exit 92 ;;
|
||||
esac
|
||||
EOF
|
||||
chmod +x "$config_path/scripts/panama-lock"
|
||||
|
||||
printf '%s\n' '{"generated":true,"path":"/fixture/generated-hyprlock.conf","fallback":false,"error":""}' \
|
||||
>"$status_response"
|
||||
: >"$generate_log"
|
||||
|
||||
qs_for_harness() {
|
||||
if [[ "$harness_pid" =~ ^[0-9]+$ && "${1:-}" == "ipc" ]]; then
|
||||
XDG_CONFIG_HOME="$config_home" XDG_STATE_HOME="$state_home" \
|
||||
PANAMA_LOCK_TEST_GENERATE_LOG="$generate_log" \
|
||||
PANAMA_LOCK_TEST_STATUS_RESPONSE="$status_response" \
|
||||
qs -p "$harness" ipc --pid "$harness_pid" "${@:2}"
|
||||
else
|
||||
XDG_CONFIG_HOME="$config_home" XDG_STATE_HOME="$state_home" \
|
||||
PANAMA_LOCK_TEST_GENERATE_LOG="$generate_log" \
|
||||
PANAMA_LOCK_TEST_STATUS_RESPONSE="$status_response" \
|
||||
qs -p "$harness" "$@"
|
||||
fi
|
||||
}
|
||||
|
||||
qs_for_harness --daemonize >"$shell_log" 2>&1 || fail 'isolated harness did not launch'
|
||||
for _ in $(seq 1 60); do
|
||||
harness_pid="$(instances_for_harness | head -1)"
|
||||
if [[ "$harness_pid" =~ ^[0-9]+$ ]] \
|
||||
&& qs_for_harness ipc show 2>/dev/null | rg -q '^target lock-screen-test$'; then
|
||||
break
|
||||
fi
|
||||
sleep 0.1
|
||||
done
|
||||
[[ "$harness_pid" =~ ^[0-9]+$ ]] || fail 'isolated harness process did not start'
|
||||
qs_for_harness ipc show 2>/dev/null | rg -q '^target lock-screen-test$' \
|
||||
|| fail 'lock-screen-test IPC target did not register'
|
||||
|
||||
for _ in $(seq 1 60); do
|
||||
initial="$(qs_for_harness ipc call lock-screen-test status)"
|
||||
[[ "$(jq -r '.busy' <<<"$initial")" == false ]] \
|
||||
&& [[ "$(jq -r '.path' <<<"$initial")" == /fixture/generated-hyprlock.conf ]] && break
|
||||
sleep 0.1
|
||||
done
|
||||
jq -e '.generated == true and .fallback == false and .path == "/fixture/generated-hyprlock.conf" and .lastError == ""' \
|
||||
<<<"$initial" >/dev/null || fail "valid helper status was not accepted: $initial"
|
||||
|
||||
# Component startup intentionally schedules one generation. Let that and any
|
||||
# preference-file load revision settle before measuring only the burst below.
|
||||
sleep 0.6
|
||||
for _ in $(seq 1 30); do
|
||||
startup="$(qs_for_harness ipc call lock-screen-test status)"
|
||||
[[ "$(jq -r '.busy' <<<"$startup")" == false ]] && break
|
||||
sleep 0.1
|
||||
done
|
||||
baseline_generations="$(wc -l <"$generate_log")"
|
||||
qs_for_harness ipc call lock-screen-test burst >/dev/null
|
||||
for _ in $(seq 1 60); do
|
||||
current_generations="$(wc -l <"$generate_log" 2>/dev/null || printf 0)"
|
||||
(( current_generations >= baseline_generations + 1 )) && break
|
||||
sleep 0.1
|
||||
done
|
||||
sleep 0.35
|
||||
current_generations="$(wc -l <"$generate_log" 2>/dev/null || printf 0)"
|
||||
[[ "$current_generations" -eq $(( baseline_generations + 1 )) ]] \
|
||||
|| fail "three rapid preferences started $(( current_generations - baseline_generations )) generations"
|
||||
|
||||
printf '%s\n' 'not json' >"$status_response"
|
||||
qs_for_harness ipc call lock-screen-test refresh >/dev/null
|
||||
for _ in $(seq 1 60); do
|
||||
malformed="$(qs_for_harness ipc call lock-screen-test status)"
|
||||
[[ "$(jq -r '.busy' <<<"$malformed")" == false ]] \
|
||||
&& [[ "$(jq -r '.lastError' <<<"$malformed")" != "" ]] && break
|
||||
sleep 0.1
|
||||
done
|
||||
jq -e '.path == "/fixture/generated-hyprlock.conf"
|
||||
and .lastError == "The lock-screen configuration could not be read."' \
|
||||
<<<"$malformed" >/dev/null || fail "malformed status replaced valid state: $malformed"
|
||||
|
||||
if rg -n 'ReferenceError|TypeError|Binding loop|Unable to assign|Cannot assign' "$shell_log"; then
|
||||
fail 'isolated harness emitted a QML runtime warning'
|
||||
fi
|
||||
|
||||
printf 'lock screen service contract: PASS\n'
|
||||
Reference in New Issue
Block a user