Drop the extension, and give the test suite a front door
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
This commit is contained in:
Gabriel Brown
Executable
+89
@@ -0,0 +1,89 @@
|
||||
#!/usr/bin/env bash
|
||||
|
||||
# Adding a settings page means editing four separate files, and missing one
|
||||
# fails quietly rather than loudly:
|
||||
#
|
||||
# SettingsSidebar.qml the row you click
|
||||
# SettingsShell.qml the case that maps that row to a component, AND the
|
||||
# Component declaration itself
|
||||
# ShellState.qml the allow-list openSettings() checks -- a page missing
|
||||
# here silently redirects to Home, so a deep link or a
|
||||
# search result lands on the wrong page with no error
|
||||
# modules/settings/qmldir the component registration -- without it the page
|
||||
# is "not a type" and the whole settings window fails
|
||||
# to load, taking every other page with it
|
||||
#
|
||||
# Nothing at runtime cross-checks the four. This does, statically.
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
||||
settings_dir="$repo_dir/config/dot/quickshell/modules/settings"
|
||||
sidebar="$settings_dir/SettingsSidebar.qml"
|
||||
shell_file="$settings_dir/SettingsShell.qml"
|
||||
qmldir="$settings_dir/qmldir"
|
||||
shell_state="$repo_dir/config/dot/quickshell/services/ShellState.qml"
|
||||
|
||||
fail() {
|
||||
printf 'settings nav contract: %s\n' "$1" >&2
|
||||
exit 1
|
||||
}
|
||||
|
||||
for required in "$sidebar" "$shell_file" "$qmldir" "$shell_state"; do
|
||||
[[ -r "$required" ]] || fail "cannot read $required"
|
||||
done
|
||||
|
||||
# ── Every sidebar row resolves everywhere ────────────────────────────────────
|
||||
pages="$(grep -oE '\{ page: "[a-z-]+"' "$sidebar" | sed 's/.*"\(.*\)"/\1/')"
|
||||
[[ -n "$pages" ]] || fail 'no pages found in the sidebar -- this contract is not reading it correctly'
|
||||
|
||||
allowed_line="$(grep -m1 'const allowed = \[' "$shell_state")" \
|
||||
|| fail 'could not find the allow-list in ShellState'
|
||||
|
||||
while read -r page; do
|
||||
[[ -n "$page" ]] || continue
|
||||
|
||||
# Home is the switch's default arm rather than a case, since it is also
|
||||
# where an unknown page falls back to.
|
||||
if [[ "$page" != "home" ]]; then
|
||||
grep -qE "case \"$page\": return [a-zA-Z]+;" "$shell_file" \
|
||||
|| fail "the sidebar offers \"$page\" but SettingsShell has no case for it, so clicking it shows Home"
|
||||
fi
|
||||
|
||||
grep -qF "\"$page\"" <<<"$allowed_line" \
|
||||
|| fail "\"$page\" is missing from ShellState's allow-list, so openSettings(\"$page\") silently redirects to Home"
|
||||
done <<<"$pages"
|
||||
|
||||
# ── Every routed component is declared and registered ────────────────────────
|
||||
# The case arms name a Component id; each must have a declaration, and the type
|
||||
# it instantiates must appear in qmldir.
|
||||
while read -r component; do
|
||||
[[ -n "$component" ]] || continue
|
||||
|
||||
declaration="$(grep -oE "Component \{ id: $component; [A-Za-z]+ \{\} \}" "$shell_file")" \
|
||||
|| fail "SettingsShell routes to \"$component\" but never declares it"
|
||||
|
||||
type_name="$(sed -E 's/.*; ([A-Za-z]+) \{\} \}/\1/' <<<"$declaration")"
|
||||
grep -qE "^$type_name [0-9.]+ $type_name\.qml$" "$qmldir" \
|
||||
|| fail "$type_name is not registered in modules/settings/qmldir -- it will fail to load as \"not a type\", and the whole settings window fails with it"
|
||||
|
||||
[[ -r "$settings_dir/$type_name.qml" ]] \
|
||||
|| fail "$type_name is registered in qmldir but $type_name.qml does not exist"
|
||||
done < <({
|
||||
grep -oE 'case "[a-z-]+": return [a-zA-Z]+;' "$shell_file" | sed -E 's/.*return ([a-zA-Z]+);/\1/'
|
||||
grep -oE 'default: return [a-zA-Z]+;' "$shell_file" | sed -E 's/.*return ([a-zA-Z]+);/\1/'
|
||||
} | sort -u)
|
||||
|
||||
# ── Every page file is reachable ─────────────────────────────────────────────
|
||||
# A page nobody can navigate to is dead code that still has to compile. The
|
||||
# scaffold SettingsPage.qml is the one file here that is a base class rather
|
||||
# than a page.
|
||||
while read -r page_file; do
|
||||
type_name="$(basename "$page_file" .qml)"
|
||||
[[ "$type_name" == "SettingsPage" ]] && continue
|
||||
|
||||
grep -qE "; $type_name \{\} \}" "$shell_file" \
|
||||
|| fail "$type_name.qml exists but nothing in SettingsShell instantiates it"
|
||||
done < <(find "$settings_dir" -maxdepth 1 -name '*Page.qml')
|
||||
|
||||
printf 'settings nav contract: PASS\n'
|
||||
Reference in New Issue
Block a user