Gabriel Brown
8be3fc2fdd
Four places in the entire shell could reach Settings. The bar, where a person looks first, was not one of them -- and Pill has routed right-click to a secondaryActivated signal all along, which nothing connected, so the gesture did nothing on every widget in the bar. Each widget now opens the page that owns its settings: the clock and the calendar reminder open Date & Time, weather opens Home, the vitals readout opens Appearance, the status glyphs open Network & Devices, the media readout opens Sound, and the privacy indicator opens Privacy & Security. Left-click behaviour is untouched. Two routing bugs found while picking those destinations, both of the same kind and both invisible from the code, since each page reads perfectly well on its own: weather routed to Appearance while every weather control lives on Home, so searching "temperature unit" opened a page without it. vitals routed to Appearance, but the refresh interval sat on Home while the toggles it governs sat on Appearance -- one concept split across two pages, which is exactly what the ownership rule forbids. The interval now sits beside the toggles and Home's stub card is gone. The jump contract guards the failure mode these share. openSettings() falls back to Home for an unknown page, sensibly and completely silently, so a typo or a later rename turns a right-click into "opens the wrong page" with nothing logged. It also fails a Pill-based bar widget that leaves right-click unconnected, since that is how the gesture came to be inert everywhere in the first place. A third instance of the routing bug is still open: followMouse and pointerSensitivity sit in the input group, which routes to Keyboard, while both render on Mouse. Fixing it is a two-line group change in PreferenceSchema.qml, which codex currently owns, so the contract that catches all three lands with that fix rather than red. Claude-Session: https://claude.ai/code/session_01BRvzt4H8XXLPVH5MyYdk9L
51 lines
2.2 KiB
Bash
Executable File
51 lines
2.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Every "open the settings for this" jump must land somewhere real.
|
|
#
|
|
# ShellState.openSettings() validates its argument against an allow-list and
|
|
# falls back to Home for anything unknown. That fallback is sensible and it is
|
|
# also completely silent: a typo, or a page renamed later, turns a right-click
|
|
# into "opens Settings on the wrong page" with nothing logged and no error.
|
|
#
|
|
# Before this, exactly four places in the entire shell could reach Settings, so
|
|
# the risk was small. The bar now offers a jump on every widget, which makes the
|
|
# fallback worth guarding.
|
|
|
|
set -uo pipefail
|
|
|
|
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
shell_state="$repo_dir/config/dot/quickshell/services/ShellState.qml"
|
|
modules="$repo_dir/config/dot/quickshell/modules"
|
|
|
|
fail() {
|
|
printf 'settings jump contract: %s\n' "$1" >&2
|
|
exit 1
|
|
}
|
|
|
|
allowed_line="$(grep -m1 'const allowed = \[' "$shell_state")" \
|
|
|| fail 'could not find the allow-list in ShellState'
|
|
|
|
jumps="$(grep -rhoE 'openSettings\("[a-z-]+"\)' "$modules" 2>/dev/null \
|
|
| sed 's/openSettings("//; s/")//' | sort -u)"
|
|
[[ -n "$jumps" ]] || fail 'found no settings jumps at all -- this contract is not reading the modules correctly'
|
|
|
|
count=0
|
|
while read -r page; do
|
|
[[ -n "$page" ]] || continue
|
|
grep -qF "\"$page\"" <<<"$allowed_line" \
|
|
|| fail "a jump opens \"$page\", which ShellState does not allow -- openSettings falls back to Home silently, so this reads as a right-click that goes to the wrong page"
|
|
count=$((count + 1))
|
|
done <<<"$jumps"
|
|
|
|
# The bar is where a person looks first, and Pill has offered a right-click
|
|
# signal all along that nothing connected -- so the gesture did nothing on every
|
|
# widget in the bar. Anything built on Pill that can be configured should say so.
|
|
for widget in Clock WeatherWidget VitalsWidget StatusCluster MediaWidget; do
|
|
file="$modules/bar/$widget.qml"
|
|
[[ -r "$file" ]] || continue
|
|
grep -q 'onSecondaryActivated' "$file" \
|
|
|| fail "$widget has no right-click jump; Pill routes right-click to secondaryActivated, so leaving it unconnected makes the gesture silently inert"
|
|
done
|
|
|
|
printf 'settings jump contract: PASS (%d distinct destinations)\n' "$count"
|