Gabriel Brown
e1faaf7a76
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
96 lines
3.9 KiB
Bash
Executable File
96 lines
3.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# A search result must open the page that actually contains the setting.
|
|
#
|
|
# Every schema group routes to one page in services/SettingsSearch.qml, and the
|
|
# ownership rule in modules/settings/README.md derives a setting's owner from
|
|
# that route. Nothing checked the two agreed, and two groups had drifted:
|
|
#
|
|
# weather routed to Appearance while every weather control lived on Home, so
|
|
# searching "temperature unit" opened a page without it.
|
|
#
|
|
# vitals routed to Appearance, but the refresh interval sat on Home while the
|
|
# toggles it governs sat on Appearance -- one concept, two pages, which is
|
|
# precisely what the ownership rule forbids.
|
|
#
|
|
# Neither is visible from the code: each page is coherent on its own, and only
|
|
# following a search result reveals the mismatch.
|
|
#
|
|
# Groups whose settings are driven by bespoke UI rather than schema-bound rows
|
|
# are skipped, because there is nothing to locate.
|
|
|
|
set -uo pipefail
|
|
|
|
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
schema="$repo_dir/config/dot/quickshell/config/PreferenceSchema.qml"
|
|
search="$repo_dir/config/dot/quickshell/services/SettingsSearch.qml"
|
|
pages_dir="$repo_dir/config/dot/quickshell/modules/settings"
|
|
shell_file="$pages_dir/SettingsShell.qml"
|
|
|
|
fail() {
|
|
printf 'search routing contract: %s\n' "$1" >&2
|
|
exit 1
|
|
}
|
|
|
|
routes="$(grep -oE '"[a-zA-Z]+": "[a-z-]+"' "$search" | tr -d '"' | tr ':' ' ')"
|
|
[[ -n "$routes" ]] || fail 'no group routes found -- this contract is not reading SettingsSearch correctly'
|
|
|
|
# page id -> Page component file, as SettingsShell maps them.
|
|
page_file() {
|
|
# Derived from SettingsShell rather than restated here. This was a
|
|
# hand-written list of every page, which meant adding one made this contract
|
|
# fail with "not a known page" -- a sixth place to register a page, and the
|
|
# sixth chance to forget. The shell already maps page -> component id and
|
|
# component id -> type, and the type names its file.
|
|
local page="$1" component type
|
|
component="$(grep -oE "case \"$page\": return [a-zA-Z]+;" "$shell_file" \
|
|
| sed -E 's/.*return ([a-zA-Z]+);/\1/' | head -1)"
|
|
if [[ -z "$component" ]]; then
|
|
# Home is the switch's default arm rather than a case.
|
|
[[ "$page" == "home" ]] || { printf ''; return; }
|
|
component="homePage"
|
|
fi
|
|
type="$(grep -oE "Component \{ id: $component; [A-Za-z]+ \{\} \}" "$shell_file" \
|
|
| sed -E 's/.*; ([A-Za-z]+) \{\} \}/\1/' | head -1)"
|
|
[[ -n "$type" ]] || { printf ''; return; }
|
|
printf '%s.qml' "$type"
|
|
}
|
|
|
|
violations=0
|
|
checked=0
|
|
|
|
while read -r group page; do
|
|
[[ -n "$group" && -n "$page" ]] || continue
|
|
|
|
target="$(page_file "$page")"
|
|
[[ -n "$target" ]] || fail "group \"$group\" routes to \"$page\", which is not a known page"
|
|
[[ -r "$pages_dir/$target" ]] || fail "group \"$group\" routes to \"$page\" but $target does not exist"
|
|
|
|
# Keys belonging to this group.
|
|
keys="$(awk -v g="\"$group\"" '
|
|
/key: "/ { match($0, /key: "[a-zA-Z]+"/); k = substr($0, RSTART+6, RLENGTH-7) }
|
|
$0 ~ "group: " g { if (k != "") print k; k = "" }
|
|
' "$schema" | sort -u)"
|
|
|
|
while read -r key; do
|
|
[[ -n "$key" ]] || continue
|
|
|
|
# Only settings rendered as schema-bound rows can be located at all.
|
|
homes="$(grep -rl "setting: \"$key\"" "$pages_dir"/*Page.qml 2>/dev/null | xargs -n1 basename 2>/dev/null || true)"
|
|
[[ -n "$homes" ]] || continue
|
|
|
|
checked=$((checked + 1))
|
|
grep -qx "$target" <<<"$homes" && continue
|
|
|
|
printf ' %s (group "%s") routes to %s but appears only on: %s\n' \
|
|
"$key" "$group" "$page" "$(tr '\n' ' ' <<<"$homes")" >&2
|
|
violations=$((violations + 1))
|
|
done <<<"$keys"
|
|
done <<<"$routes"
|
|
|
|
if (( violations > 0 )); then
|
|
fail "$violations setting(s) route to a page that does not contain them, so searching for them opens the wrong page"
|
|
fi
|
|
|
|
printf 'search routing contract: PASS (%d routed settings)\n' "$checked"
|