Gabriel Brown
e1faaf7a76
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
69 lines
2.6 KiB
Bash
Executable File
69 lines
2.6 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Every pinned application must resolve to an installed desktop entry.
|
|
#
|
|
# DockBody drops a pin it cannot resolve rather than drawing a broken icon,
|
|
# which is the right behavior at runtime and a terrible one to debug: a typo in
|
|
# the shipped list, or an application that changed its desktop id, simply
|
|
# removes an icon from the dock with nothing logged.
|
|
#
|
|
# Also asserts the Settings entry resolves and carries Panama's own icon, since
|
|
# it is the first pin and the one most likely to be wrong after a rename.
|
|
|
|
set -euo pipefail
|
|
|
|
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
harness="$repo_dir/config/dot/quickshell/dock-pin-harness.qml"
|
|
config_home="$(mktemp -d /tmp/panama-dockpins.XXXXXX)"
|
|
|
|
fail() {
|
|
printf 'dock pins contract: %s\n' "$1" >&2
|
|
exit 1
|
|
}
|
|
|
|
run() { XDG_CONFIG_HOME="$config_home" qs -p "$harness" "$@"; }
|
|
harness_pid=""
|
|
|
|
cleanup() {
|
|
# By PID, never `pkill -f dock-pin-harness`: that pattern also matches the
|
|
# shell running this script.
|
|
[[ -n "$harness_pid" ]] && kill "$harness_pid" >/dev/null 2>&1 || true
|
|
rm -rf "$config_home"
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
XDG_CONFIG_HOME="$config_home" qs -p "$harness" --daemonize >/dev/null
|
|
for _ in $(seq 1 40); do
|
|
run ipc show 2>/dev/null | rg -q '^target dock-pin-test$' && break
|
|
sleep 0.1
|
|
done
|
|
run ipc show 2>/dev/null | rg -q '^target dock-pin-test$' || fail 'test IPC target did not start'
|
|
harness_pid="$(run list | awk '/Process ID:/ { print $3; exit }')"
|
|
|
|
# DesktopEntries populates asynchronously; asking before it has finished reports
|
|
# every pin as missing, which is a false failure rather than a real one.
|
|
loaded=0
|
|
for _ in $(seq 1 60); do
|
|
loaded="$(run ipc call dock-pin-test count 2>/dev/null || printf 0)"
|
|
[[ "$loaded" =~ ^[0-9]+$ ]] && (( loaded > 0 )) && break
|
|
sleep 0.25
|
|
done
|
|
(( loaded > 0 )) || fail 'no desktop entries were discovered at all'
|
|
|
|
state="$(run ipc call dock-pin-test resolve)"
|
|
|
|
missing="$(jq -r '.missing | join(", ")' <<<"$state")"
|
|
[[ -z "$missing" ]] || fail "these pinned applications do not resolve and would vanish from the dock: $missing"
|
|
|
|
jq -e '.first.id == "panama-settings" and .first.found == true' <<<"$state" >/dev/null \
|
|
|| fail "Panama Settings is not the first pin, or does not resolve: $(jq -c .first <<<"$state")"
|
|
jq -e '.first.icon == "panama-settings"' <<<"$state" >/dev/null \
|
|
|| fail "Settings is not using Panama's own icon: $(jq -r .first.icon <<<"$state")"
|
|
|
|
icon="$HOME/.local/share/icons/hicolor/scalable/apps/panama-settings.svg"
|
|
[[ -r "$icon" ]] || fail "the icon it names is not installed at $icon"
|
|
|
|
trap - EXIT
|
|
cleanup
|
|
printf 'dock pins contract: PASS (%s pins, all resolve)\n' "$(jq -r .total <<<"$state")"
|