Gabriel Brown
e1faaf7a76
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
96 lines
3.3 KiB
Bash
Executable File
96 lines
3.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# No settings page may hand off to a GNOME panel that Panama itself owns.
|
|
#
|
|
# Panama absorbed Users, Sharing, Printers, Online Accounts and others one page
|
|
# at a time. Each time, the rows pointing at GNOME's equivalent stayed where
|
|
# they were -- so a settings app whose stated purpose is to make GNOME Settings
|
|
# unnecessary shipped four separate doors back to it, two of them inside a card
|
|
# headed "these areas remain owned by Fedora".
|
|
#
|
|
# Nothing failed. Every row worked exactly as written. The rows were simply no
|
|
# longer true, and no test could notice because none of them knew what Panama
|
|
# had come to own in the meantime.
|
|
#
|
|
# This reads the sidebar for the pages that exist and the pages for the panels
|
|
# they hand off, and fails on any overlap. It is deliberately derived from both
|
|
# sides rather than from a hand-kept list, so absorbing the next page cannot
|
|
# leave a stale door behind.
|
|
#
|
|
# Read-only.
|
|
|
|
set -uo pipefail
|
|
|
|
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
settings_dir="$repo_dir/config/dot/quickshell/modules/settings"
|
|
sidebar="$settings_dir/SettingsSidebar.qml"
|
|
|
|
fail() {
|
|
printf 'gnome handoff contract: %s\n' "$1" >&2
|
|
exit 1
|
|
}
|
|
|
|
[[ -r "$sidebar" ]] || fail "missing $sidebar"
|
|
|
|
# GNOME panel names that correspond to a Panama page. Only entries whose panel
|
|
# genuinely duplicates a Panama page belong here: "network" stays off it because
|
|
# Panama has no VPN or per-connection routing, and "online-accounts" is listed
|
|
# because Panama has an Online Accounts page -- but adding an account still has
|
|
# to go through GOA's own dialog, so that one exception is named explicitly.
|
|
declare -A OWNED=(
|
|
[printers]=printers
|
|
[online-accounts]=accounts
|
|
[sharing]=sharing
|
|
[users]=users
|
|
[system\ users]=users
|
|
)
|
|
|
|
# Handoffs that are correct despite naming an owned panel, with the reason.
|
|
# Anything here must be justified, not merely tolerated.
|
|
declare -A ALLOWED=(
|
|
["OnlineAccountsPage.qml:online-accounts"]="adding an account requires GOA's own dialog"
|
|
)
|
|
|
|
pages="$(grep -oE '\{ *page: "[a-z-]+"' "$sidebar" | sed 's/.*"\(.*\)"/\1/' | sort -u)"
|
|
[[ -n "$pages" ]] || fail 'no pages could be read from the sidebar, so this proves nothing'
|
|
|
|
has_page() {
|
|
grep -qx "$1" <<<"$pages"
|
|
}
|
|
|
|
violations=0
|
|
checked=0
|
|
|
|
while IFS= read -r hit; do
|
|
file="${hit%%:*}"
|
|
base="$(basename "$file")"
|
|
# openGnomePanel("a") or openGnomePanel("a", "b") -> "a" / "a b"
|
|
panel="$(sed -E 's/.*openGnomePanel\("([^"]+)"(, *"([^"]+)")?\).*/\1 \3/' <<<"$hit" \
|
|
| sed 's/ *$//')"
|
|
[[ -n "$panel" ]] || continue
|
|
checked=$((checked + 1))
|
|
|
|
owner="${OWNED[$panel]:-}"
|
|
[[ -n "$owner" ]] || continue
|
|
has_page "$owner" || continue
|
|
|
|
key="$base:${panel// /-}"
|
|
if [[ -n "${ALLOWED[$key]:-}" ]]; then
|
|
continue
|
|
fi
|
|
|
|
printf 'gnome handoff contract: %s hands "%s" to GNOME, but Panama owns the "%s" page\n' \
|
|
"$base" "$panel" "$owner" >&2
|
|
violations=$((violations + 1))
|
|
done < <(grep -rno --include='*.qml' -E 'openGnomePanel\("[^"]*"(, *"[^"]*")?\)' "$settings_dir")
|
|
|
|
(( checked > 0 )) || fail 'no handoffs were examined, so this proves nothing'
|
|
|
|
if (( violations > 0 )); then
|
|
printf 'Each of these sends someone to GNOME for a page this app already has.\n' >&2
|
|
exit 1
|
|
fi
|
|
|
|
printf 'gnome handoff contract: ok (%d handoffs checked against %d pages)\n' \
|
|
"$checked" "$(wc -l <<<"$pages")"
|