Gabriel Brown
94353aa0bd
Audited bar, dock, quick settings, date menu and Settings for three things: a setting reachable in one UI but not another, a setting that exists but is unreachable anywhere, and UI that states something false. Night Light was fully exposed in Quick Settings and had no control anywhere in Settings. It now has a card on Displays, where GNOME also puts it, with on/off, schedule, times and temperature. Adding those controls would have shipped the exact defect this audit exists to find. NightLight declared enabled, temperature and automatic as bindings on the store, but toggle() assigns to them, and an assignment destroys a QML binding permanently -- so the service wrote to the store and never read from it again. The Settings controls would have written values the service ignored, while Quick Settings kept working. It now follows the store. Every other service was swept for the same pattern; this was the only one. The night light schedule was two hardcoded literals, so the hours could not be changed. They are schema keys now, with a row that renders 17.5 as "5:30 PM" and honours the 24-hour preference rather than showing a decimal nobody reads as a time. keyboardLayout was in the schema and read by input.lua but had no control anywhere: configurable in principle, unreachable in practice. It is surfaced on Input & Shortcuts as read-only, with the reason, because it needs a compositor reload and a control implying instant apply would be a smaller lie but still a lie. Caffeine was a Quick Settings toggle mentioned only in a subtitle in Settings. It has a real control now. Claude-Session: https://claude.ai/code/session_01BRvzt4H8XXLPVH5MyYdk9L
32 lines
1.1 KiB
QML
32 lines
1.1 KiB
QML
// A time of day, stored as a decimal hour.
|
|
//
|
|
// SliderRow would render 17.5 as "17.50", which is not how anyone reads a
|
|
// clock. This is the same control with the readout formatted as a time, so the
|
|
// night light schedule says "5:30 PM" rather than a number you have to convert.
|
|
//
|
|
// Honours the 24-hour clock preference, because a user who has asked for 18:30
|
|
// everywhere else should not be shown 6:30 PM here.
|
|
|
|
import QtQuick
|
|
import qs.config
|
|
import qs.services
|
|
|
|
SliderRow {
|
|
id: root
|
|
|
|
// SliderRow renders `unit` after the number; a time needs the whole readout
|
|
// replaced, so the formatting is done here instead.
|
|
function display(value: real): string {
|
|
const hour = Math.floor(value);
|
|
const minute = Math.round((value - hour) * 60);
|
|
const padded = String(minute).padStart(2, "0");
|
|
|
|
if (Settings.use24Hour)
|
|
return `${String(hour).padStart(2, "0")}:${padded}`;
|
|
|
|
const suffix = hour < 12 ? "AM" : "PM";
|
|
const twelve = hour % 12 === 0 ? 12 : hour % 12;
|
|
return `${twelve}:${padded} ${suffix}`;
|
|
}
|
|
}
|