Gabriel Brown
e1faaf7a76
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
73 lines
3.3 KiB
Bash
Executable File
73 lines
3.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Versioned upgrades for settings.json.
|
|
#
|
|
# The schema says what a setting IS; it cannot say what a setting USED to be.
|
|
# Rename a key, change its units, or split one setting into two, and the stored
|
|
# value stops being recognized -- and unrecognized keys are deliberately carried
|
|
# through untouched, so the user's choice silently stops taking effect with
|
|
# nothing to explain it.
|
|
#
|
|
# The list of migrations is empty today, which is exactly why this is tested
|
|
# now: the first time it runs for real will be against somebody's actual
|
|
# settings during an upgrade, and that is a poor moment to discover how it
|
|
# behaves. The harness supplies fixture steps, including one that throws.
|
|
|
|
set -uo pipefail
|
|
|
|
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
harness="$repo_dir/config/dot/quickshell/migrations-harness.qml"
|
|
|
|
fail() {
|
|
printf 'migrations contract: %s\n' "$1" >&2
|
|
exit 1
|
|
}
|
|
|
|
[[ -r "$harness" ]] || fail "the harness is missing: $harness"
|
|
|
|
out="$(timeout 60 qs -p "$harness" 2>&1 | grep -o 'PANAMA-MIGRATIONS .*' | sed 's/^PANAMA-MIGRATIONS //')"
|
|
[[ -n "$out" ]] || fail 'the harness produced no result'
|
|
jq -e . >/dev/null 2>&1 <<<"$out" || fail "the harness did not emit JSON: $out"
|
|
|
|
check() {
|
|
jq -e "$1" >/dev/null <<<"$out" || fail "$2 -- got $(jq -c "$3" <<<"$out")"
|
|
}
|
|
|
|
# A file written before versioning existed is stamped, NOT migrated. Running
|
|
# the list against it would apply upgrades designed for schemas it never had.
|
|
check '.unversioned.v == 1 and .unversioned.migrated == false and .unversioned.untouched == true' \
|
|
'a file with no schemaVersion must be stamped at the baseline without being migrated' '.unversioned'
|
|
|
|
# The stamp has to reach disk. Reported as changed-but-not-migrated, it would
|
|
# otherwise live only in memory and be redone on every single launch.
|
|
check '.unversioned.changed == true' \
|
|
'stamping a pre-versioning file must be reported as a change so it gets written' '.unversioned'
|
|
|
|
# A file from the future must not be rewritten at all.
|
|
check '.future.changed == false' \
|
|
'a file from a newer version must not be written back' '.future'
|
|
|
|
# Every step above the stored version runs, in order.
|
|
check '.upgrade.v == 3 and .upgrade.b == 2 and .upgrade.c == "three" and .upgrade.count == 2' \
|
|
'an older file must run each pending step in order and end at the current version' '.upgrade'
|
|
|
|
# Already current: nothing runs, nothing is touched.
|
|
check '.current.migrated == false and .current.kept == true and .current.b == true' \
|
|
'a file already at the current version must be left alone' '.current'
|
|
|
|
# A file from a NEWER Panama is left completely alone. Downgrading keys is not
|
|
# something this can do correctly, and unknown keys are already preserved.
|
|
check '.future.v == 9 and .future.migrated == false and .future.kept == true' \
|
|
'a file from a newer version must not be modified or downgraded' '.future'
|
|
|
|
# A failing step stops at the last good version. Skipping past it would lose
|
|
# the conversion forever; failing the whole load would cost every setting.
|
|
check '.failure.v == 3 and .failure.count == 2 and .failure.kept == true' \
|
|
'a failing step must stop at the last good version, keeping the steps that succeeded' '.failure'
|
|
|
|
# The promise that makes rollback safe.
|
|
check '.preserved.kept == true' \
|
|
'a migration must not discard keys it does not recognize' '.preserved'
|
|
|
|
printf 'migrations contract: PASS\n'
|