Fix worker image missing docker CLI; harden spawn-failure handling
Build and Push Spoon Images / quality (push) Successful in 1m47s
Build and Push Spoon Images / build-images (push) Successful in 6m33s

Root cause of the prod empty-response: the spoon-agent-worker image shipped
without a docker CLI binary, so it could never launch the codex job container.
On Debian trixie (the bun base) 'docker.io' + --no-install-recommends installs
the daemon package but omits the client (split into 'docker-cli'), leaving no
'docker' on PATH. execa('docker', ...) hit ENOENT, and with reject:false that
resolves with exitCode undefined -> coerced to 0 -> looked like a successful
empty run -> 'Codex completed without producing an assistant response'.

- agent-worker.Dockerfile: drop docker.io, install the official static docker
  CLI client pinned to 29.5.3 (matches the host daemon) to /usr/local/bin/docker
- runtime/docker.ts: normalizeRunResult() so a spawn failure (exitCode null) is
  always a non-zero exit carrying the real reason, never a silent empty success
- tests: cover the spawn-failure and normal-result paths
This commit is contained in:
Gabriel Brown
2026-06-24 06:31:17 -04:00
parent a2976481d7
commit 40a6dd78e4
3 changed files with 63 additions and 9 deletions
@@ -43,4 +43,27 @@ describe('Docker runtime', () => {
'/tmp/spoon-job:/workspace:z',
);
});
test('treats a spawn failure (no exitCode) as a non-zero exit, not empty success', async () => {
const { normalizeRunResult } = await loadVolumeSpec();
// This is what execa returns with `reject: false` when the runtime binary is
// missing (e.g. no `docker` CLI in the worker image): exitCode is undefined.
const result = normalizeRunResult(
{ exitCode: undefined, shortMessage: 'spawn docker ENOENT' },
undefined,
(value) => value,
);
expect(result.exitCode).toBe(1);
expect(result.output).toContain('spawn docker ENOENT');
});
test('passes through a normal command result unchanged', async () => {
const { normalizeRunResult } = await loadVolumeSpec();
const result = normalizeRunResult(
{ exitCode: 0, shortMessage: undefined },
'hello',
(value) => value,
);
expect(result).toEqual({ exitCode: 0, output: 'hello' });
});
});