chore: fix eslint errors introduced across phases 1-3

apps/agent-worker/src/runtime/docker.ts

@@ -244,7 +244,9 @@ export const inspectUserBoxStatus = async (
   const running = runningField === 'true';
   return {
     running,
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- empty field means "no image"
     image: imageField || null,
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- empty field means "not started"
     startedAt: running ? startedAtField || null : null,
     memoryLimitBytes: Number(memoryField) || null,
   };

apps/agent-worker/src/terminal-token.ts

@@ -37,7 +37,8 @@ export const parseBoxTokenUsername = (token: string): string | null => {
   const parts = token.split('.');
   if (parts.length !== 4 || parts[1] !== 'box') return null;
   const username = parts[2];
-  return username ? username : null;
+  if (!username) return null;
+  return username;
 };
 
 // User-scoped variant authorizing a terminal connection to a user's box.

apps/agent-worker/src/worker.ts

@@ -293,7 +293,7 @@ const createInteractionRequest = async (args: {
     ...args,
   });
 
-const patchInteractionRequest = async (args: {
+const _patchInteractionRequest = async (args: {
   interactionId: Id<'agentInteractionRequests'>;
   status: 'pending' | 'answered' | 'approved' | 'rejected' | 'expired';
   response?: string;
@@ -1179,6 +1179,7 @@ export const replyToInteraction = async (
     externalRequestId: string;
     response: string;
   },
+  // eslint-disable-next-line @typescript-eslint/require-await -- keep async so callers receive a rejected promise
 ) => {
   // Every runtime now runs its CLI non-interactively inside the box, so no
   // runtime emits an interaction request that expects a reply.

apps/agent-worker/tests/unit/agent-runtime.test.ts

@@ -9,9 +9,9 @@ describe('agent runtime registry', () => {
   test('registerAdapter/getAdapter resolves a registered runtime', () => {
     const fake: AgentRuntime = {
       name: 'codex',
-      prepareAuth: async () => {},
-      runTurn: async () => ({}),
-      abort: async () => {},
+      prepareAuth: () => Promise.resolve(),
+      runTurn: () => Promise.resolve({}),
+      abort: () => Promise.resolve(),
     };
     registerAdapter('codex', () => fake);
     expect(getAdapter('codex').name).toBe('codex');

apps/next/src/app/(app)/spoons/[spoonId]/agent/[jobId]/page.tsx

@@ -1,6 +1,5 @@
 'use client';
 
-import type { FunctionReturnType } from 'convex/server';
 import { useEffect } from 'react';
 import Link from 'next/link';
 import { useParams, useRouter } from 'next/navigation';
@@ -16,10 +15,7 @@ const AgentWorkspacePage = () => {
   const router = useRouter();
   const params = useParams<{ spoonId: string; jobId: string }>();
   const jobId = params.jobId as Id<'agentJobs'>;
-  const job = useQuery(api.agentJobs.get, { jobId }) as
-    | FunctionReturnType<typeof api.agentJobs.get>
-    | null
-    | undefined;
+  const job = useQuery(api.agentJobs.get, { jobId });
 
   useEffect(() => {
     if (job?.threadId) router.replace(`/threads/${job.threadId}`);

apps/next/src/app/(app)/threads/[threadId]/page.tsx

@@ -1,6 +1,5 @@
 'use client';
 
-import type { FunctionReturnType } from 'convex/server';
 import { useState } from 'react';
 import Link from 'next/link';
 import { useParams, useRouter } from 'next/navigation';
@@ -34,10 +33,7 @@ const ThreadDetailPage = () => {
   const router = useRouter();
   const params = useParams<{ threadId: string }>();
   const threadId = params.threadId as Id<'threads'>;
-  const details = useQuery(api.threads.get, { threadId }) as
-    | FunctionReturnType<typeof api.threads.get>
-    | null
-    | undefined;
+  const details = useQuery(api.threads.get, { threadId });
   const createJob = useMutation(api.agentJobs.createForThread);
   const markResolved = useMutation(api.threads.markResolved);
   const cancel = useMutation(api.threads.cancel);

apps/next/src/app/api/threads/[threadId]/message/route.ts

@@ -1,4 +1,3 @@
-import type { FunctionReturnType } from 'convex/server';
 import { NextResponse } from 'next/server';
 import { proxyWorker } from '@/lib/agent-worker-proxy';
 import { convexAuthNextjsToken } from '@convex-dev/auth/nextjs/server';
@@ -40,7 +39,7 @@ export const POST = async (
       api.threads.get,
       { threadId },
       { token },
-    )) as FunctionReturnType<typeof api.threads.get> | null;
+    ));
     if (details === null) {
       return NextResponse.json({ error: 'Thread not found.' }, { status: 404 });
     }

apps/next/src/components/agent-workspace/agent-workspace-shell.tsx

@@ -1,6 +1,5 @@
 'use client';
 
-import type { FunctionReturnType } from 'convex/server';
 import type { CSSProperties, PointerEvent as ReactPointerEvent } from 'react';
 import { useCallback, useEffect, useState } from 'react';
 import { useMutation, useQuery } from 'convex/react';
@@ -61,10 +60,7 @@ type PendingOverwrite = {
 };
 
 export const AgentWorkspaceShell = ({ jobId }: { jobId: Id<'agentJobs'> }) => {
-  const job = useQuery(api.agentJobs.get, { jobId }) as
-    | FunctionReturnType<typeof api.agentJobs.get>
-    | null
-    | undefined;
+  const job = useQuery(api.agentJobs.get, { jobId });
   const messages =
     useQuery(
       api.agentJobs.listMessages,

apps/next/tests/component/xterm-session.test.tsx

@@ -13,11 +13,11 @@ const {
   writeTextSpy,
 } = vi.hoisted(() => ({
   openSpy: vi.fn(),
-  wsInstances: [] as Array<{
+  wsInstances: [] as {
     url: string;
     send: ReturnType<typeof vi.fn>;
     close: ReturnType<typeof vi.fn>;
-  }>,
+  }[],
   fetchSpy: vi.fn(),
   fitSpy: vi.fn(),
   selectionHandlers: [] as (() => void)[],
@@ -110,17 +110,23 @@ beforeEach(() => {
   fetchSpy.mockResolvedValue({
     ok: true,
     status: 200,
-    json: async () => ({ url: 'ws://x' }),
-    text: async () => '',
+    json: () => Promise.resolve({ url: 'ws://x' }),
+    text: () => Promise.resolve(''),
   });
   vi.stubGlobal('WebSocket', FakeWebSocket);
   vi.stubGlobal('fetch', fetchSpy);
   vi.stubGlobal(
     'ResizeObserver',
     class {
-      observe() {}
-      disconnect() {}
-      unobserve() {}
+      observe() {
+        /* noop */
+      }
+      disconnect() {
+        /* noop */
+      }
+      unobserve() {
+        /* noop */
+      }
     },
   );
   Object.defineProperty(document, 'fonts', {