Gabriel Brown
e1faaf7a76
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
100 lines
3.9 KiB
Bash
Executable File
100 lines
3.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Network & Devices reads real NetworkManager and BlueZ state.
|
|
#
|
|
# Both of the bugs this contract exists to prevent were silent. Neither logged
|
|
# anything; both produced a page that looked fine and told the user something
|
|
# false:
|
|
#
|
|
# * the device lookups used enum names that do not exist
|
|
# (NetworkDeviceType.Wifi rather than DeviceType.Wifi), so they returned
|
|
# null and the page reported "No Wi-Fi adapter" on a machine whose Wi-Fi was
|
|
# connected;
|
|
# * signalStrength is 0.0-1.0, not a percentage, so thresholds written for
|
|
# 0-100 put every network including the connected one in the bottom bucket.
|
|
#
|
|
# So this compares what the service resolves against what NetworkManager itself
|
|
# reports, rather than merely checking the service does not crash.
|
|
|
|
set -euo pipefail
|
|
|
|
repo_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd)"
|
|
harness="$repo_dir/config/dot/quickshell/connectivity-harness.qml"
|
|
|
|
fail() {
|
|
printf 'connectivity contract: %s\n' "$1" >&2
|
|
exit 1
|
|
}
|
|
|
|
command -v nmcli >/dev/null || fail 'nmcli is needed to check the service against reality'
|
|
|
|
run() { qs -p "$harness" "$@"; }
|
|
harness_pid=""
|
|
|
|
cleanup() {
|
|
run ipc call connectivity-test setActive false >/dev/null 2>&1 || true
|
|
# By PID: never `pkill -f connectivity-harness`, which also matches the
|
|
# shell running this script.
|
|
[[ -n "$harness_pid" ]] && kill "$harness_pid" >/dev/null 2>&1 || true
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
qs -p "$harness" --daemonize >/dev/null
|
|
for _ in $(seq 1 40); do
|
|
run ipc show 2>/dev/null | rg -q '^target connectivity-test$' && break
|
|
sleep 0.1
|
|
done
|
|
run ipc show 2>/dev/null | rg -q '^target connectivity-test$' || fail 'test IPC target did not start'
|
|
harness_pid="$(run list | awk '/Process ID:/ { print $3; exit }')"
|
|
|
|
# Scanning only runs while the page says it is visible.
|
|
run ipc call connectivity-test setActive true >/dev/null
|
|
sleep 3
|
|
|
|
state="$(run ipc call connectivity-test status)"
|
|
|
|
# ── Devices the service finds must match the ones NetworkManager reports ─────
|
|
nm_wifi="$(nmcli -t -f DEVICE,TYPE device | awk -F: '$2 == "wifi" { print $1; exit }')"
|
|
nm_wired="$(nmcli -t -f DEVICE,TYPE,STATE device | awk -F: '$2 == "ethernet" && $3 == "connected" { print $1; exit }')"
|
|
|
|
if [[ -n "$nm_wifi" ]]; then
|
|
[[ "$(jq -r .wifiDevice <<<"$state")" == "$nm_wifi" ]] \
|
|
|| fail "NetworkManager reports Wi-Fi device '$nm_wifi' but the service found '$(jq -r .wifiDevice <<<"$state")'"
|
|
fi
|
|
if [[ -n "$nm_wired" ]]; then
|
|
[[ "$(jq -r .wiredConnected <<<"$state")" == "true" ]] \
|
|
|| fail "NetworkManager reports '$nm_wired' connected but the service says it is not"
|
|
fi
|
|
|
|
# ── Signal strength is a ratio, and the labels must reflect that ─────────────
|
|
while IFS='|' read -r value expect; do
|
|
got="$(run ipc call connectivity-test labelFor "$value")"
|
|
[[ "$got" == "$expect" ]] || fail "signal $value labeled '$got', expected '$expect'"
|
|
done <<'CASES'
|
|
1.0|Excellent
|
|
0.85|Excellent
|
|
0.6|Good
|
|
0.4|Fair
|
|
0.1|Weak
|
|
0.0|No signal
|
|
CASES
|
|
|
|
# If a network is connected, it must not be described as the weakest possible
|
|
# thing -- that was the visible symptom of reading the ratio as a percentage.
|
|
active_ssid="$(jq -r .activeSsid <<<"$state")"
|
|
if [[ -n "$active_ssid" ]]; then
|
|
strength="$(jq -r .activeStrength <<<"$state")"
|
|
awk -v s="$strength" 'BEGIN { exit !(s >= 0 && s <= 1) }' \
|
|
|| fail "signalStrength $strength is outside 0.0-1.0; the label buckets assume a ratio"
|
|
fi
|
|
|
|
# ── Bluetooth ────────────────────────────────────────────────────────────────
|
|
if [[ "$(bluetoothctl list 2>/dev/null | wc -l)" -gt 0 ]]; then
|
|
[[ "$(jq -r .adapter <<<"$state")" == "true" ]] \
|
|
|| fail 'an adapter is present but the service did not find it'
|
|
fi
|
|
|
|
trap - EXIT
|
|
cleanup
|
|
printf 'connectivity contract: PASS\n'
|