Gabriel Brown
e1faaf7a76
Phase 6, the last of the fresh-install spec. 159 scripts lose their .sh: 110 contracts, 47 Vicinae commands, 2 compositor contracts. A shebang and the executable bit already select the interpreter. The extension only ever added something that had to stay in sync, and the rename proved the point twice over in the space of an hour. The spec's stated risk was Vicinae's script discovery. One script was renamed and reloaded on its own before the other 46 followed; it came back as scripts:panama.capture and all 47 resolve. What the probe turned up instead is that the extension was never only a filename: Vicinae's command IDs embed it, so every ID changed. Nothing in this repository refers to them, so nothing breaks. The only trace is Vicinae's metadata.json, whose visited map had two Panama entries that are now orphaned -- two commands lost their usage ranking and will earn it back. Worth knowing before anyone renames these again on a machine that has a keybind pointing at one. Rewriting the references by exact filename missed two things it structurally could not see: a name built from a variable, settings-$page.sh, and a glob, -name '*.sh'. Both were in the contract that counts the generated commands, which promptly reported 47 expected and 0 found. The mechanical part of a rename is the part that looks finished. The three subcommands. panama doctor fronts a health check that already existed and already ran at the end of every install but could not be reached from a terminal. panama upgrade re-runs the installer from anywhere. panama test runs the suite, which had no entry point at all -- 121 files that were the main safety net in this repository and were invisible in it. Writing that runner found three tests nothing was running. calendar_agenda_bridge_test, home_assistant_bridge_test and kdeconnect_bridge_test are unittest suites without the executable bit, so no contract invoked them and the first draft of the runner skipped them silently. All three pass, and have passed unobserved for weeks. The runner collects *_test.py as well now, because a runner with a blind spot is worse than no runner for the same reason a dependency checker with one is: it reports PASS. Six worktrees pruned. Each was re-checked rather than trusted to the spec's list, and two needed it: panama-commands is not on feat/panama-commands but on feat/gnome-tweaks-parity, and fix/panama-displays-review reads [ahead 3] -- ahead of its remote, not of main, with every commit patch-equivalent to landed work. roadmap-completion stays; it has five commits that are genuinely unlanded. The branches are left alone: pruning a worktree costs nothing, deleting a branch is a decision. 121 contracts pass. Claude-Session: https://claude.ai/code/session_01NvgBuSWB5sE43yWmg21ozj
104 lines
5.3 KiB
Markdown
104 lines
5.3 KiB
Markdown
# Settings Home & Phone Completion Implementation Plan
|
|
|
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
|
|
|
**Goal:** Finish the Home & Phone Settings page on Panama's shared Settings vocabulary and give the global reset path a named, durable Home preference API.
|
|
|
|
**Architecture:** `HomePhonePage` adopts `SettingsPage` for the shared scrolling/title/lede scaffold while retaining its specialized catalog, reorder, alias, and phone controls. `HomePreferences.resetHomeDefaults()` becomes the sole Home-store reset boundary: it returns the store to fresh-install state and writes immediately so `SystemSettings.restoreDefaults()` can call it without mutating aliases.
|
|
|
|
**Tech Stack:** Quickshell 0.3 QML, QtQuick, Bash contract tests, Hyprland.
|
|
|
|
**Spec:** `docs/superpowers/specs/2026-08-17-panama-cohesion-design.md`
|
|
|
|
## Global Constraints
|
|
|
|
- Do not touch `SystemSettings.qml`, `PreferenceSchema.qml`, keybinds, or Claude's shared row implementations in this branch.
|
|
- Preserve ordered Home favorites, aliases, first-four Control Center badges, search, drag and keyboard reorder, retry state, Home Assistant status copy, and BlueBubbles availability behavior.
|
|
- Automated tests must not toggle or dim a real light and must not launch BlueBubbles.
|
|
- New behavior follows red-green TDD; fixture and state directories remain isolated from the live desktop.
|
|
- No mock phase and no new visual direction: this is cohesion work against the already-approved design.
|
|
|
|
---
|
|
|
|
### Task 1: Shared Home & Phone page and named reset boundary
|
|
|
|
**Files:**
|
|
- Modify: `config/dot/quickshell/config/HomePreferences.qml`
|
|
- Modify: `config/dot/quickshell/home-preferences-harness.qml`
|
|
- Modify: `config/dot/quickshell/modules/settings/HomePhonePage.qml`
|
|
- Modify only if required for shared vocabulary compatibility: `config/dot/quickshell/modules/settings/HomeFavoriteCard.qml`
|
|
- Modify only if required for shared vocabulary compatibility: `config/dot/quickshell/modules/settings/AvailableLightRow.qml`
|
|
- Modify: `tests/quickshell/home-preferences-contract`
|
|
- Modify: `tests/quickshell/home-phone-settings-contract`
|
|
|
|
**Interfaces:**
|
|
- Consumes: `SettingsPage { title; lede; default content }`, existing `SettingsCard`, `SettingRow`, `ActionRow`, `TextRow`, `HomeAssistant`, `SystemSettings.bluebubblesAvailable`, and writable `HomePreferences` adapter state.
|
|
- Produces: `HomePreferences.resetHomeDefaults(): void`, which sets `favorites` to `[]`, sets `initialized` to `false`, clears stale save error state, and invokes `preferencesFile.writeAdapter()` immediately after stopping the debounce timer.
|
|
|
|
- [ ] **Step 1: Write failing contracts**
|
|
|
|
Add `reset()` to the isolated `home-pref-test` IPC harness. Extend `home-preferences-contract` to seed aliases/order, invoke reset, and require both IPC state and `panama-home.json` to become exactly `{"initialized":false,"favorites":[]}` without waiting for the 180 ms debounce interval. Extend `home-phone-settings-contract` to require `SettingsPage {`, `title: "Home & Phone"`, and the existing lede through `lede:`, while rejecting the copied root `Flickable` scaffold.
|
|
|
|
- [ ] **Step 2: Run contracts to verify RED**
|
|
|
|
```bash
|
|
tests/quickshell/home-preferences-contract
|
|
tests/quickshell/home-phone-settings-contract
|
|
```
|
|
|
|
Expected: the preference contract fails because `reset` is missing; the page contract fails because the page still owns a copied `Flickable` scaffold.
|
|
|
|
- [ ] **Step 3: Implement the reset API and shared page scaffold**
|
|
|
|
Implement this public boundary in `HomePreferences.qml`:
|
|
|
|
```qml
|
|
function resetHomeDefaults(): void {
|
|
persistTimer.stop();
|
|
values.favorites = [];
|
|
values.initialized = false;
|
|
root.saveError = "";
|
|
preferencesFile.writeAdapter();
|
|
}
|
|
```
|
|
|
|
Replace the `HomePhonePage` root `Item` plus nested `Flickable`/title/lede scaffold with:
|
|
|
|
```qml
|
|
SettingsPage {
|
|
id: root
|
|
objectName: "home-phone-page"
|
|
title: "Home & Phone"
|
|
lede: "Choose what appears in Control Center and keep phone continuity close at hand."
|
|
// Existing SettingsCard content remains in order.
|
|
}
|
|
```
|
|
|
|
Use shared `ActionRow` or `TextRow` only where their single-action/read-only contracts preserve all current status and accessibility behavior. Keep specialized rows when the shared primitive would lose information.
|
|
|
|
- [ ] **Step 4: Run focused contracts to GREEN**
|
|
|
|
```bash
|
|
tests/quickshell/home-preferences-contract
|
|
tests/quickshell/home-phone-settings-contract
|
|
tests/quickshell/settings-pages-contract
|
|
tests/quickshell/settings-rows-contract.sh
|
|
tests/quickshell/settings-commit-reset-contract
|
|
```
|
|
|
|
Expected: every command exits 0; no test launches BlueBubbles or changes a real Home Assistant entity.
|
|
|
|
- [ ] **Step 5: Commit**
|
|
|
|
```bash
|
|
git add config/dot/quickshell/config/HomePreferences.qml \
|
|
config/dot/quickshell/home-preferences-harness.qml \
|
|
config/dot/quickshell/modules/settings/HomePhonePage.qml \
|
|
config/dot/quickshell/modules/settings/HomeFavoriteCard.qml \
|
|
config/dot/quickshell/modules/settings/AvailableLightRow.qml \
|
|
tests/quickshell/home-preferences-contract \
|
|
tests/quickshell/home-phone-settings-contract \
|
|
docs/superpowers/plans/2026-08-18-settings-home-phone-completion.md
|
|
git commit -m "Finish Home and Phone settings cohesion"
|
|
```
|